Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 21410 int #14483

Merged
merged 171 commits into from
Jan 27, 2025
Merged

B 21410 int #14483

merged 171 commits into from
Jan 27, 2025

Conversation

CoryKleinjanCACI
Copy link
Contributor

@CoryKleinjanCACI CoryKleinjanCACI commented Dec 30, 2024

B-21410

Summary

Adding the IOSHUT and IDSHUT (International Origin and Destination Shuttle Service Items) to the application. They should have the ability to be created, approved, rejected, resubmitted and priced as part of a payment packet.

How to test

  1. Access the Milmove

  2. Login as a Customer

  3. Create a new move with an HHG

  4. Login as a Service Counselor

  5. Approve the move details

  6. Login as a TOO

  7. Approve the shipment and Submit

  8. Login as the Prime

  9. Update the HHG with dates and weights

  10. Add an IOSHUT and IDSHUT service item

  11. Login as TOO

  12. Reject the service items

  13. Using swagger submit the following to mto-service-items/{id}, changing the reServiceCode to match appropriately:
    {
    "reServiceCode": "IDSHUT",
    "updateReason": "A reason that differs from the previous reason",
    "modelType": "UpdateMTOServiceItemInternationalShuttle",
    "requestApprovalsRequestedStatus": true
    }

  14. Login as TOO

  15. Verify that the service items are available for approval

  16. Approve the IOSHUT and IDSHUT

  17. Login as Prime

  18. Create a payment request that include IOSHUT and IDSHUT

  19. Login as TOO and verify that the payment service items are priced for the requested Payment Packet

@CoryKleinjanCACI CoryKleinjanCACI requested review from a team as code owners December 30, 2024 15:11
@robot-mymove
Copy link

robot-mymove commented Dec 30, 2024

Warnings
⚠️ This PR does not include changes to storybook, even though it affects component code.

Generated by 🚫 dangerJS against 10520a2

Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality is good, downstream BLs can do a lot of refinement if needed. Upstream feature is officially all in main

Able to request and resubmit international shuttle as Prime
Able to approve/reject TOO
Able to review pricing as TIO

One small thing wrong with the migration file overriding previous work for basic iHHG service items.

Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some pricing changes & a question

Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested as Prime
Approved/rejected as TOO
Able to see pricing as TIO

estimated pricing shows up
Screenshot 2025-01-24 at 4 35 22 PM

TIO pricing seems pretty different from estimated, but that can be addressed in a downstream to ensure those match up.
Screenshot 2025-01-24 at 4 36 23 PM

Meets AC, LGTM! Thanks for all the changes and sorry if it was a downer to wait for the upstreams. Nice work!

@danieljordan-caci
Copy link
Contributor

Happo approved

Copy link
Contributor

@antgmann antgmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

@antgmann
Copy link
Contributor

🦛 ✅

@CoryKleinjanCACI CoryKleinjanCACI merged commit 1dfdc8b into integrationTesting Jan 27, 2025
37 checks passed
@CoryKleinjanCACI CoryKleinjanCACI deleted the B-21410-INT branch January 27, 2025 15:52
@CoryKleinjanCACI CoryKleinjanCACI mentioned this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.

9 participants