-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B 21410 int #14483
B 21410 int #14483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality is good, downstream BLs can do a lot of refinement if needed. Upstream feature is officially all in main
Able to request and resubmit international shuttle as Prime
Able to approve/reject TOO
Able to review pricing as TIO
One small thing wrong with the migration file overriding previous work for basic iHHG service items.
migrations/app/schema/20250121153007_update_pricing_proc_to_handle_international_shuttle.up.sql
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some pricing changes & a question
migrations/app/schema/20250121153007_update_pricing_proc_to_handle_international_shuttle.up.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happo approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving
🦛 ✅ |
B-21410
Summary
Adding the IOSHUT and IDSHUT (International Origin and Destination Shuttle Service Items) to the application. They should have the ability to be created, approved, rejected, resubmitted and priced as part of a payment packet.
How to test
Access the Milmove
Login as a Customer
Create a new move with an HHG
Login as a Service Counselor
Approve the move details
Login as a TOO
Approve the shipment and Submit
Login as the Prime
Update the HHG with dates and weights
Add an IOSHUT and IDSHUT service item
Login as TOO
Reject the service items
Using swagger submit the following to mto-service-items/{id}, changing the reServiceCode to match appropriately:
{
"reServiceCode": "IDSHUT",
"updateReason": "A reason that differs from the previous reason",
"modelType": "UpdateMTOServiceItemInternationalShuttle",
"requestApprovalsRequestedStatus": true
}
Login as TOO
Verify that the service items are available for approval
Approve the IOSHUT and IDSHUT
Login as Prime
Create a payment request that include IOSHUT and IDSHUT
Login as TOO and verify that the payment service items are priced for the requested Payment Packet