Main b 21507 pod poe too validation #14400

msaki-caci · 2024-12-13T19:53:35Z

Agility ticket

Summary

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

Has the branch been pulled in and checked out?
Have the BL acceptance criteria been met for this change?
Was the CircleCI build successful?
Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

Access the
Login as a

Frontend

There are no aXe warnings for UI.
This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
There are no new console errors in the browser devtools.
There are no new console errors in the test output.
If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
This change meets the standards for Section 508 compliance.

Backend

Code follows the guidelines for Logging.
The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

Follows our guidelines for Zero-Downtime Deploys.
Have been communicated to #g-database.
Secure migrations have been tested following the instructions in our docs.

Screenshots

Add descriptions for POE/POD Locations in swagger.

Update API call to pull Port info Update MTOShipment.yaml to include Port

…Prime-Port-Update-Failure

…on-Submit-move-details-task-order-with-files

…task-order-with-files

Add POE/POD Location to MTOShipment payload Make methods to pull the port location into the payload update swagger definitions for POE/POD locations

add pppo base elizabeth

Update shipmentDisplay.test so a dash is expected

Fix check-generated-code test

…e-Failure Main b 21506 prime port update failure

MAIN B-21683

B-22132 fix amend orders link

B-21533 HQ role with Safety Move privs

Consolidate payload functions for Ports Refactor model_to_payload tests for updated Port function

robot-mymove · 2025-01-06T17:37:50Z

	Warnings
⚠️	Files located in legacy directories (src/shared or src/scenes) have been edited. Are you sure you don’t want to also relocate them to the new file structure? View the frontend file org ADR for more information

Generated by 🚫 dangerJS against d2e43bc

Use 'else if' to improve efficiency

Add poe location to ShipmentDetails.stories.jsx

Hide POE/POD Location UI if there isn't a value

Move port location formatter to formatters.js Add toTitleCase function to formatters.js Update test files

Start adding test to mto_shipment_fetcher_test.go

Fix serviceItemPortFSC to link to shipment model and pass DB argument

Update test on ShipmentAddresses.test.jsx

loganwc and others added 8 commits November 27, 2024 23:01

add 3rd address validation to payload to model for PPM shipments

3f08765

fixed check throwing false positives

883f832

Merge main

e49ddb2

Merge branch 'main' into B-21819-Prime-3rd-Address-Errors

f5e77d0

update mto_shipment_test

f8d3d3b

Merge MAIN-B-21505 into MAIN-B-21507

5ecb361

Merge MAIN-B-21505 into MAIN-B-21507

60572ec

B-21507

ea054ca

Add descriptions for POE/POD Locations in swagger.

msaki-caci changed the base branch from main to MAIN-B-21505 December 13, 2024 19:54

paulstonebraker and others added 21 commits December 16, 2024 18:59

Merge branch 'main' into B-21976-MAIN

f7bda5e

add key to column button wrapper

3e184f5

B-21507

f229337

Update API call to pull Port info Update MTOShipment.yaml to include Port

Merge branch 'main' into MAIN-B-21507

329f2d9

Merge remote-tracking branch 'origin/MAIN-B-21505' into MAIN-B-21506-…

9b1fd1f

…Prime-Port-Update-Failure

add key to sc and too queue assigned column button wrapper

13a53ce

use row.id instead of entire obj

3873375

Merge remote-tracking branch 'origin/main' into MAIN-B-21373-Validati…

a8b9fba

…on-Submit-move-details-task-order-with-files

add pppo base elizabeth

a4663e2

Merge branch 'main' into MAIN-B-21373-Validation-Submit-move-details-…

2b26f2b

…task-order-with-files

Merge branch 'main' into MAIN-B-21373-Validation-Submit-move-details-…

b436e50

…task-order-with-files

Merge branch 'main' into MAIN-B-21373-Validation-Submit-move-details-…

81417a3

…task-order-with-files

ci/cd work

b26296e

Merge branch 'main' into B-22107-DynamicDP3-Stg-Prd-deploy

9c9ce1a

Merge branch 'main' into MAIN-B-21373-Validation-Submit-move-details-…

2f64230

…task-order-with-files

Merge branch 'main' into B-22107-DynamicDP3-Stg-Prd-deploy

d0c019b

fix amend orders link after move is submitted

d5b8aff

B-21507

deeb1d5

Add POE/POD Location to MTOShipment payload Make methods to pull the port location into the payload update swagger definitions for POE/POD locations

fixed link in second spot

d8e149d

ci/cd work

ae0ba3e

Merge branch 'main' of github.com:transcom/mymove into B-21533

e06f0b2

danieljordan-caci and others added 20 commits January 3, 2025 14:17

INT to VARCHAR

28f612f

fixing variable

4ffa67d

in PEMDAS we trust

c4b7534

spelling

c09ad7d

removing FK to survive this day

75e484f

Merge branch 'main' into MAIN-B-21507_POD-POE_TOO_Validation

896b7f5

Merge pull request #14500 from transcom/B-22131

7a15309

add pppo base elizabeth

Merge branch 'main' into MAIN-B-21506-Prime-Port-Update-Failure

0088344

B-21507

d33da9a

Update shipmentDisplay.test so a dash is expected

B-21507

80aee20

Fix check-generated-code test

Merge pull request #14501 from transcom/MAIN-B-21506-Prime-Port-Updat…

8a3c33d

…e-Failure Main b 21506 prime port update failure

Merge branch 'main' into main-b-21683

fdcc4ab

Merge pull request #14507 from transcom/main-b-21683

21af774

MAIN B-21683

Merge branch 'main' into B-22132-Fix-Link-Amend-Orders

c8a859d

Merge branch 'main' into B-21533

b462f46

Merge pull request #14441 from transcom/B-22132-Fix-Link-Amend-Orders

71d62d1

B-22132 fix amend orders link

Merge branch 'main' into B-21533

ca879a3

Merge pull request #14454 from transcom/B-21533

4c18b94

B-21533 HQ role with Safety Move privs

B-21507

124d4e9

Consolidate payload functions for Ports Refactor model_to_payload tests for updated Port function

Merge branch 'main' into MAIN-B-21507_POD-POE_TOO_Validation

63c3e20

msaki-caci added 7 commits January 6, 2025 21:34

B-21507

a77c1e9

Use 'else if' to improve efficiency

B-21507

f0d0742

Add poe location to ShipmentDetails.stories.jsx

B-21507

4ed67d0

Hide POE/POD Location UI if there isn't a value

B-21507

17cb068

Move port location formatter to formatters.js Add toTitleCase function to formatters.js Update test files

B-21507

502e892

Start adding test to mto_shipment_fetcher_test.go

B-21507

f960e09

Fix serviceItemPortFSC to link to shipment model and pass DB argument

B-21507

d2e43bc

Update test on ShipmentAddresses.test.jsx

msaki-caci merged commit d66bebd into integrationTesting Jan 8, 2025
30 of 32 checks passed

msaki-caci deleted the MAIN-B-21507_POD-POE_TOO_Validation branch January 8, 2025 19:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Main b 21507 pod poe too validation #14400

Main b 21507 pod poe too validation #14400

msaki-caci commented Dec 13, 2024

robot-mymove commented Jan 6, 2025 •

edited

Loading

Main b 21507 pod poe too validation #14400

Main b 21507 pod poe too validation #14400

Conversation

msaki-caci commented Dec 13, 2024

Agility ticket

Summary

Verification Steps for the Author

Verification Steps for Reviewers

Setup to Run the Code

How to test

Frontend

Backend

Database

Any new migrations/schema changes:

Screenshots

robot-mymove commented Jan 6, 2025 • edited Loading

robot-mymove commented Jan 6, 2025 •

edited

Loading