B-21458 int2

[stevengleason-caci]

B-21458

Summary

Agility: B-21458
When the orders type is retirement OR separation, the email should state the destination address of their first shipment instead of Duty Station.
For PPMs, we need to use the Address linked to the PPM.

Previous Int PR: #14099
Update: Other emails needed updating for PPM addresses. I also moved the formatting into Address.go to keep it consistent.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

NOTE: I haven't been able to test the emails locally, but I've tested the previous PRs changes for the "Complete your PPM" email in integrationTesting

Given I am a customer
When I create a PPM for a retirement or separation with an expected departure date at least 14 days in the past
Then I will receive a "Thank you for submitting your move details" email showing the actual destination address (instead of HOS/ HOR/PLEAD)

Given the above
When a TOO approves the PPM
Then I will receive a "Your counselor has approved your move details" email showing the actual destination address (instead of HOS/ HOR/PLEAD)
And the next morning I will receive a "Complete your Personally Procured Move (PPM)" email showing the actual destination address (instead of HOS/ HOR/PLEAD)

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

[ryan-mchugh]

Emails do not seem to have the destination street address for PPM, only the city, state zip

[ryan-mchugh]

Also, to run locally, run this:

EMAIL_BACKEND=ses aws-vault exec transcom-gov-dev -- make server_run

[danieljordan-caci]

Full address is showing in the emails. LGTM!

Retirement:

Separation:

[danieljordan-caci]

Also just a heads up but the AC in this PR is NOT the AC in the BL provided. Might want to add what you've put in here to Agility.

[stevengleason-caci]

Also just a heads up but the AC in this PR is NOT the AC in the BL provided. Might want to add what you've put in here to Agility.

Yes, thanks. I've added the AC now.

[brianmanley-caci]

Looks good.