Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B19764 main fe aoa packet change text #12661

Merged
merged 3 commits into from
May 13, 2024
Merged

B19764 main fe aoa packet change text #12661

merged 3 commits into from
May 13, 2024

Conversation

JamesHawks224
Copy link
Contributor

Agility ticket

B19764

Int PR

12609

Summary

In the AOA Packet PDF download, the text label for shipment weight was changed from "- FINAL" to "- Estimated".

How to test

  • create a PPM move. Select Advance Payment.
  • login as a SC
  • find the move and open it
  • Review the advance payment and approve it.
  • Click the download link for the "AOA Packet PDF" and open the PDF.
  • On page 1, there will be a shipment weight. It should have the text "- Estimated"
  • On page 2, there will be a shipment weight. It should have the text "- Estimated"

Screenshots

image

image

@JamesHawks224 JamesHawks224 added ByteSize M&Ms Team ByteSized M&Ms MAIN labels May 13, 2024
@JamesHawks224 JamesHawks224 requested a review from a team as a code owner May 13, 2024 17:41
KonstanceH
KonstanceH approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@KonstanceH KonstanceH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

taeJungCaci
taeJungCaci approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@taeJungCaci taeJungCaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deandreJones deandreJones merged commit cf7630d into main May 13, 2024
38 checks passed
@deandreJones deandreJones deleted the b19764-main-fe-aoa-packet-change-text branch May 13, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonstanceH KonstanceH KonstanceH approved these changes

@taeJungCaci taeJungCaci taeJungCaci approved these changes

@deandreJones deandreJones deandreJones approved these changes

Assignees
No one assigned
Labels
ByteSize M&Ms Team ByteSized M&Ms MAIN
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JamesHawks224 @deandreJones @taeJungCaci @KonstanceH