Merge pull request #14313 from transcom/sequencer_test_improvements-MAIN

Sequencer test improvements MAIN

migrations/app/migrations_manifest.txt

@@ -1032,4 +1032,5 @@
 20241109002854_add_gsr_table_to_move_history.up.sql
 20241111203514_add_external_crate_and_remove_icrtsa.up.sql
 20241111223224_change_international_sit_services_to_accessorials.up.sql
+20241202163059_create_test_sequence_dev_env.up.sql
 20241203024453_add_ppm_max_incentive_column.up.sql

migrations/app/secure/20241202163059_create_test_sequence_dev_env.up.sql

@@ -0,0 +1,7 @@
+-- Local test migration.
+-- This will be run on development environments.
+-- It should mirror what you intend to apply on loadtest/demo/exp/stg/prd
+-- DO NOT include any sensitive data.
+
+-- Create test_sequence in migration, moved from sequencer_test.go
+CREATE SEQUENCE IF NOT EXISTS test_sequence;

pkg/db/sequence/sequencer_test.go

@@ -13,9 +13,7 @@ type SequenceSuite struct {
 }
 
 func (suite *SequenceSuite) SetupTest() {
-	err := suite.DB().RawQuery("CREATE SEQUENCE IF NOT EXISTS test_sequence;").Exec()
-	suite.NoError(err, "Error creating test sequence")
-	err = suite.DB().RawQuery("SELECT setval($1, 1);", testSequence).Exec()
+	err := suite.DB().RawQuery("SELECT setval($1, 1);", testSequence).Exec()
 	suite.NoError(err, "Error resetting sequence")
 }