Skip to content

Commit

Permalink
Merge pull request #14338 from transcom/MAIN-B-21568-Show-UB-Preappro…
Browse files Browse the repository at this point in the history
…ved-Service-Items

Main-B-21568 show ub preapproved service items
  • Loading branch information
brianmanley-caci authored Dec 10, 2024
2 parents 7ef40cf + 7cb82f6 commit 60c57cf
Show file tree
Hide file tree
Showing 33 changed files with 2,210 additions and 71 deletions.
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,8 @@ endif
./scripts/openapi bundle -o swagger/ ## Bundles the API definition files into a complete specification
touch .swagger_build.stamp

server_generate: .server_generate.stamp
.PHONY: server_generate
server_generate: .server_generate.stamp ## generate the server code from swagger files

.server_generate.stamp: .check_go_version.stamp .check_gopath.stamp .swagger_build.stamp bin/swagger $(wildcard swagger/*.yaml) ## Generate golang server code from Swagger files
scripts/gen-server
Expand Down
1 change: 1 addition & 0 deletions migrations/app/migrations_manifest.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1033,6 +1033,7 @@
20241109002854_add_gsr_table_to_move_history.up.sql
20241111203514_add_external_crate_and_remove_icrtsa.up.sql
20241111223224_change_international_sit_services_to_accessorials.up.sql
20241126222026_add_sort_column_to_re_service_items.up.sql
20241127133504_add_indexes_speed_up_counseling_offices.up.sql
20241202163059_create_test_sequence_dev_env.up.sql
20241203024453_add_ppm_max_incentive_column.up.sql
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
ALTER TABLE re_service_items ADD COLUMN IF NOT EXISTS sort int;

COMMENT ON COLUMN re_service_items.sort IS 'Sort order for service items to be displayed for a given shipment type.';

update re_service_items set sort = 1 where service_id in (select id from re_services where code in ('ISLH','UBP'));
--A shipment will only have either POEFSC or PODFSC, so we set them to the same sort value
update re_service_items set sort = 2 where service_id in (select id from re_services where code = 'POEFSC');
update re_service_items set sort = 2 where service_id in (select id from re_services where code = 'PODFSC');
update re_service_items set sort = 3 where service_id in (select id from re_services where code in ('IHPK','IUBPK'));
update re_service_items set sort = 4 where service_id in (select id from re_services where code in ('IHUPK','IUBUPK'));
6 changes: 6 additions & 0 deletions pkg/gen/ghcapi/configure_mymove.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import (
"github.com/transcom/mymove/pkg/gen/ghcapi/ghcoperations/ppm"
"github.com/transcom/mymove/pkg/gen/ghcapi/ghcoperations/pws_violations"
"github.com/transcom/mymove/pkg/gen/ghcapi/ghcoperations/queues"
"github.com/transcom/mymove/pkg/gen/ghcapi/ghcoperations/re_service_items"
"github.com/transcom/mymove/pkg/gen/ghcapi/ghcoperations/report_violations"
"github.com/transcom/mymove/pkg/gen/ghcapi/ghcoperations/shipment"
"github.com/transcom/mymove/pkg/gen/ghcapi/ghcoperations/tac"
Expand Down Expand Up @@ -215,6 +216,11 @@ func configureAPI(api *ghcoperations.MymoveAPI) http.Handler {
return middleware.NotImplemented("operation ppm.FinishDocumentReview has not yet been implemented")
})
}
if api.ReServiceItemsGetAllReServiceItemsHandler == nil {
api.ReServiceItemsGetAllReServiceItemsHandler = re_service_items.GetAllReServiceItemsHandlerFunc(func(params re_service_items.GetAllReServiceItemsParams) middleware.Responder {
return middleware.NotImplemented("operation re_service_items.GetAllReServiceItems has not yet been implemented")
})
}
if api.CustomerGetCustomerHandler == nil {
api.CustomerGetCustomerHandler = customer.GetCustomerHandlerFunc(func(params customer.GetCustomerParams) middleware.Responder {
return middleware.NotImplemented("operation customer.GetCustomer has not yet been implemented")
Expand Down
280 changes: 280 additions & 0 deletions pkg/gen/ghcapi/embedded_spec.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 60c57cf

Please sign in to comment.