Skip to content

Conversation

rkitover
Copy link

curl now comes with windows, and will work in a default cygwin install.

Signed-off-by: Rafael Kitover [email protected]

rkitover added 2 commits June 2, 2020 19:31
curl now comes with windows, and will work in a default cygwin install.

Signed-off-by: Rafael Kitover <[email protected]>
Use "$0" instead of "apt-cyg" to call self, thus not requiring self in
PATH.
Pass -s to all curl commands to make output less noisy.

Signed-off-by: Rafael Kitover <[email protected]>
@equalman
Copy link

equalman commented Sep 5, 2023 via email

Signed-off-by: Rafael Kitover <[email protected]>
@rkitover
Copy link
Author

rkitover commented Sep 5, 2023

Added, do you want me to make any other changes?

@lhartmann
Copy link

I am not a member of the project, but please allow me to make a suggestion.

Maybe instead of hardcoding curl/wget/lynx everywhere, improve on the original wget function with fallback. I would suggest renaming it to download_file, and fine tune each command in there. Something like

download_file() {
    local FILE="$1"
    local URL="$2"
    # try curl
    # try wget
    # try lynx
    # fail
}

I would probably also make the fallbacks silent, as there is no point in warning against something that works.

@equalman
Copy link

equalman commented Sep 25, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants