Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates assessment codec #381

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

michaelfarrell76
Copy link
Member

fixes error in codec

@michaelfarrell76 michaelfarrell76 requested review from a team and abrantesarthur January 24, 2025 18:59
@@ -4,8 +4,10 @@ import * as t from 'io-ts';

export const AssessmentRiskLogic = t.intersection([
t.partial({
riskAssignment: t.type({
riskAssignment: t.partial({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can define a RiskAssignmentCodec as a schemaToCodec of RiskAssignmentInput?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be ideal to define these in privacy-types, but I don't think we can import the RiskAssignmentInput schema into it 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think this has a graphql codec

Copy link
Member

@abrantesarthur abrantesarthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@michaelfarrell76 michaelfarrell76 merged commit e461409 into main Jan 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants