add support for syncing Assessments from OneTrust to Transcend #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anotherminh
approved these changes
Jan 14, 2025
| const { risks, ...restQuestion } = question; | ||
| const enrichedRisks = (risks ?? []).map((risk) => { | ||
| const details = riskDetailsById[risk.riskId]; | ||
| // FIXME: missing the risk meta data and links to the assessment |
There was a problem hiding this comment.
did you mean to do this FIXME
There was a problem hiding this comment.
Yes! I still need to check what Informa means by "risk metadata and links" and add those here.
michaelfarrell76
approved these changes
Jan 15, 2025
lvonessen
reviewed
Jan 15, 2025
| | file | Path to the file to pull the resource into. Its format must match the fileFormat argument. | string | N/A | false | | ||
| | fileFormat | The format of the output file. | string | csv | false | | ||
| | resource | The resource to pull from OneTrust. For now, only assessments is supported. | string | assessments | false | | ||
| | dryRun | Whether to export the resource to a file rather than sync to Transcend. | boolean | false | false | |
There was a problem hiding this comment.
Is it worth trying to convey that some arguments are conditionally required? E.g. I assume if you have --dryRun then file is required, and if you don't then transcendAuth/transcendUrl are required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest starting the review from the command's entrypoint
cli-sync-ot.ts.See updated README for instructions of how to test this. Locally, you'd do
yarn ts-node ./src/cli-sync-ot.ts. instead ofyarn cli-sync-ot.cli-pull-ot->cli-sync-ot.Note that requests to
importOneTrustAssessmentFormsfail because we need to update the endpoint, not because the cli has bugs.Related Issues
Security Implications
[none]
System Availability
[none]