Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Initialization in AcknowledgePossession, possible race condition #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Initialization in AcknowledgePossession, possible race condition #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,21 @@ void APAPlayerControllerBase::AcknowledgePossession(APawn* P)
}
```

Because possible race condition, specially with bad network conditions, the `Pawn` `PlayerController` could not be replicated yet, so I do `RefreshAbilityActorInfo()` when the `Pawn` is replicated to the `PlayerController`.

```c++
void APAPlayerControllerBase::OnRep_Pawn()
{
Super::OnRep_Pawn();

APACharacterBase* CharacterBase = Cast<APACharacterBase>(GetPawn());
if (CharacterBase)
{
CharacterBase->GetAbilitySystemComponent()->RefreshAbilityActorInfo();
}
}
```

For player controlled characters where the `ASC` lives on the `PlayerState`, I typically initialize the server in the `Pawn's` `PossessedBy()` function and initialize on the client in the `Pawn's` `OnRep_PlayerState()` function. This ensures that the `PlayerState` exists on the client.

```c++
Expand Down