[Fix] fire projectiles in multiplayer #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheep0729
changed the title
|
related issue: #111 |
sheep0729
changed the title
sheep0729
changed the title
|
Hi, thanks for the pull request. I see one of your changes upgrades to 5.3. I'm not supporting 5.3 just yet, so I can't accept this PR as I don't want to upgrade the whole project to 5.3 yet. |
|
Sorry, It was a mistake I made yesterday. I pushed a lot of irrelevant commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests on my own computer: When playing on a 2-player listen server, the client cannot fire while aiming. If there are three players, the second client cannot fire at all.
I believe the cause of this issue is that the server is not receiving the first anim nofity from fire montages. I changed the montage tick type of
Event.Montage.SpawnProjectilefrom "Queued" to "Branching Point", and it seems to work.I also unchecked "Should Fire in Editor"s to get rid of error logs when launching the editor.
Thanks.