Skip to content

Conversation

@thomasDOTwtf
Copy link

adding a default user role to newly created objects.
This is an alternate approach to issue #11

@TimoStahl
Copy link

We had the same issues, this change fixed it

@thomasDOTwtf
Copy link
Author

@LizardM4 might you be able to review and merge?

@5p4k
Copy link
Contributor

5p4k commented Jul 15, 2020

@thomasDOTwtf sure!

@BlueTeck It seems sensible that a new user assumes the app user role by default, but I think we should use the Role::APP_USER constant from Kanboard/Core/Security/Role rather than hardcoding the value.

@TimoStahl
Copy link

TimoStahl commented Jul 16, 2020

In my private fork, I've changed the constructor instead and didn't pass an default role.

https://github.com/trajche/SamlAuth/blob/master/User/SamlUserProvider.php#L39

public function __construct($username, $email, $name, $role = '')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants