-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make series tree-shakable #1714
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
SlicedSilver
added
enhancement
Feature requests, and general improvements.
breaking change
Changes the API in a non backwards compatible way.
labels
Nov 4, 2024
SlicedSilver
requested changes
Nov 5, 2024
This reverts commit 0cd7d11.
SlicedSilver
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle this looks good and we can proceed with a PR to merge the updated tests and documentation into this branch.
Once that PR is merged into this branch then we can add approval to this PR.
illetid
force-pushed
the
feature/add-series-tree-shakable
branch
from
November 11, 2024 13:13
7c7015f
to
140a653
Compare
…-test addSeries test and website changes
SlicedSilver
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Changes the API in a non backwards compatible way.
enhancement
Feature requests, and general improvements.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR: enhancement
To achieve tree-shaking on series, removed
add<SeriesType>Series
methods, added genericaddSeries
method instead that expects series definition with internalcreatePaneView
. To prevent exposingIChartModel
to public I used@internal
jsdoc tag to remove them from.d.ts
.Tests will be added in separate PR #1720 that will be merge into this after we fully agree with the implementation details, as not to bloat this PR to make it reviewable.
PR checklist:
Overview of change:
Is there anything you'd like reviewers to focus on?