switch to svg (#530)

- switch `Content-Type` header to `image/svg+xml`
- adds format parameter to `open_bytes_in_browser` so that both svg and png show up in testing

tests/ethereum/test_uniswap_v3_live_stop_loss.py

@@ -682,10 +682,10 @@ def test_refresh_visualisations(
     large_image_png = loop.runner.run_state.visualisation.large_image_png
 
     if os.environ.get('SHOW_IMAGE'):
-        open_bytes_in_browser(small_image)
-        open_bytes_in_browser(small_image_dark)
-        open_bytes_in_browser(large_image)
-        open_bytes_in_browser(large_image_dark)
+        open_bytes_in_browser(small_image, format="svg")
+        open_bytes_in_browser(small_image_dark, format="svg")
+        open_bytes_in_browser(large_image, format="svg")
+        open_bytes_in_browser(large_image_dark, format="svg")
         open_bytes_in_browser(small_image_png)
         open_bytes_in_browser(large_image_png)
 

tradeexecutor/strategy/pandas_trader/runner.py

@@ -141,6 +141,10 @@ def update_strategy_thinking_image_data(self, small_figure, large_figure):
         small_image, small_image_dark = self.get_small_images(small_figure)
         large_image, large_image_dark = self.get_large_images(large_figure)
 
+        # uncomment if you want light mode for Discord
+        # small_figure.update_layout(template="plotly")
+        # large_figure.update_layout(template="plotly")
+
         # don't need the dark images for png (only post light images to discord)
         small_image_png, _ = self.get_image_and_dark_image(small_figure, format="png", width=512, height=512)
         large_image_png, _ = self.get_image_and_dark_image(large_figure, format="png", width=1024, height=1024)

tradeexecutor/visual/image_output.py

@@ -59,14 +59,14 @@ def open_plotly_figure_in_browser(figure: go.Figure, height:int = 512, width: in
     webbrowser.open(f"file://{path.as_posix()}")
 
 
-def open_bytes_in_browser(data: bytes) -> None:
+def open_bytes_in_browser(data: bytes, format="png") -> None:
     """Open bytes in a browser. Useful for debugging.
 
     :param data:
         bytes data to be used to create an image
     """
 
-    path = Path("/tmp/test-image.png")
+    path = Path(f"/tmp/test-image.{format}")
     with open(path, "wb") as out:
         out.write(data)
 

tradeexecutor/webhook/api.py

@@ -177,8 +177,7 @@ def web_visulisation(request: Request):
         if not data:
             return exception_response(501, detail=f"Image data not available. It will be generated on the first strategy cycle.")
 
-        # TODO: Switch to SVG
-        r = Response(content_type="image/png")
+        r = Response(content_type="image/svg+xml")
         r.body = data
         return r
     elif type =="large":
@@ -191,8 +190,7 @@ def web_visulisation(request: Request):
         if not data:
             return exception_response(501, detail=f"Image data not available. It will be generated on the first strategy cycle.")
 
-        # TODO: Switch to SVG
-        r = Response(content_type="image/png")
+        r = Response(content_type="image/svg+xml")
         r.body = data
         return r
     else: