Demo of accessing invalid strips #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
closing, this is superseded by #25. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
not to be merged
This PR includes the really dumb implementation of the invalid modules that I worked on in December. Basically, I added printouts to initializeStripStatus to get the x, y, z, phi_span, detector, layer, and isStereo information from CMSSW.
In WriteMemoryFile.cc, I copied and pasted these values and added a hit with a dummy index of -7 to mark the invalid module.
A useful hypernews discussion about other ways to access this information can be found here.
I’m not sure what the easiest way is to have a proper implementation of this in the mkFit workflow.