Set Ingress Classname By Values #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notation is for Kubernetes > 1.18.
ErikRehmTT
reviewed
Jan 21, 2025
Member
ErikRehmTT
left a comment
ErikRehmTT
left a comment
There was a problem hiding this comment.
- Could you please give a summary on the pull request, why this change is needed?
- Please bump the version of the helm-chart so it can be released automatically after merge to main
Member
|
The change is needed to set a specific ingressClassName based on the values.yaml. Based on the environment it may change, example is nginx or gce. |
ErikRehmTT
reviewed
Jan 22, 2025
ErikRehmTT
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is needed to set a specific ingressClassName based on the values.yaml. Based on the environment it may change, example is nginx or gce.