Skip to content

Update Readiness Endpoint In test.guide Helm Chart #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinGroscheTT merged 3 commits into from
Dec 6, 2024
Merged

Update Readiness Endpoint In test.guide Helm Chart #43

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4291dd
Set readinessProbe for maintenance mode (#41)
MartinGroscheTT Dec 5, 2024
fe59e04
Add review notes (#41)
MartinGroscheTT Dec 5, 2024
194e361
Update chart version (#41)
MartinGroscheTT Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions charts/test-guide/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,18 @@ spec:
timeoutSeconds: 5
failureThreshold: 5
readinessProbe:
httpGet:
path: /api/health/ready
port: {{ .Values.service.targetPort }}
exec:
command:
- /bin/sh
- -c
- |
if curl -s http://localhost:{{ .Values.service.targetPort }}{{ .Values.service.readinessPath | default "/api/health/ready" }}; then
exit 0
elif curl -s http://localhost:{{ .Values.service.targetPort }}/api/health/live; then
exit 0
else
Copy link
Member

@ErikRehmTT ErikRehmTT Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a more complex solution than I expected. In this implementation it doesn't make much sense, as it would be enough to just check .../live for the same result.

If we want to do a more complex check if test.guide is in maintenance mode, we would need to check for http code 503 and a set Retry-After Header

exit 1
fi
initialDelaySeconds: 30
periodSeconds: 10
timeoutSeconds: 5
Expand Down
Loading