Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Google VertexAI Provider Support #22

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Saturn225
Copy link

No description provided.

@Saturn225 Saturn225 marked this pull request as draft December 23, 2024 20:17
@Saturn225
Copy link
Author

Saturn225 commented Dec 23, 2024

Need minor tweaks in models.rs . I will wrap up and push it too

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saturn225 is this ready for review?

@Saturn225
Copy link
Author

@nirga Yes, it's ready for review. Just need minor tweaks in models.rs and tests to be added

@nirga
Copy link
Member

nirga commented Jan 6, 2025

@Saturn225 please follow the issue guidelines and send for review when you've done everything - including tests etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants