-
Notifications
You must be signed in to change notification settings - Fork 0
ユーザーアイコンのキャッシュ管理の責務を移動 #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kitsne241
wants to merge
10
commits into
main
Choose a base branch
from
feat/user-icon-sw-cache
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7b99184
UserIcon コンポーネントで Query を使用しない
kitsne241 81896aa
アイコン画像のキャッシュ設定を追加
kitsne241 2109bf9
image-proxy.trap.jp から画像を利用
kitsne241 e1fa148
キャッシュ戦略を SWR に変更
kitsne241 85547f4
Revert "キャッシュ戦略を SWR に変更"
kitsne241 a4a4cd4
Revert "image-proxy.trap.jp から画像を利用"
kitsne241 34ee59a
Merge remote-tracking branch 'origin/main' into feat/user-icon-sw-cache
kitsne241 6382e5a
レビュー箇所を変更
kitsne241 417dabb
アイコンが正常にロードされないので loading="lazy" を削除
kitsne241 ff4b98f
v-img に乗り換え
kitsne241 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The v-tooltip is positioned outside the v-avatar but references it via activator. This creates a DOM structure where the tooltip's visual container (div.rounded-circle) wraps both the avatar and the tooltip element. However, with the current structure, the tooltip will always be rendered in the DOM even when idTooltip is false, which could have performance implications in lists with many UserIcon components.
Consider moving the v-tooltip inside the v-avatar or conditionally rendering it only when idTooltip is true.