Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TraqChannelService #94

Merged
merged 9 commits into from
Jan 25, 2025
Merged

TraqChannelService #94

merged 9 commits into from
Jan 25, 2025

Conversation

helgev-traP
Copy link
Contributor

エラー以外はたぶんできているが、エラーの扱いがこれでいいのかがわからず。

@helgev-traP
Copy link
Contributor Author

うそ、できてない気がする

@helgev-traP helgev-traP force-pushed the server-impl-traq-channel-service branch from 066ae5a to 1abc28f Compare January 25, 2025 09:41
@helgev-traP
Copy link
Contributor Author

TraqChannelRaw以下の構造体でserde::Deserializeしてもらうために使わないフィールドをそのまま残してる。なにかいい方法ありますか。

server/src/traq/channel/error.rs Outdated Show resolved Hide resolved
server/src/traq/channel/impl.rs Outdated Show resolved Hide resolved
server/src/traq/channel/impl.rs Outdated Show resolved Hide resolved
server/src/traq/channel/impl.rs Outdated Show resolved Hide resolved
@helgev-traP helgev-traP force-pushed the server-impl-traq-channel-service branch from 3b1b843 to 4e072e0 Compare January 25, 2025 11:53
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ直したらいけそう

server/src/traq/channel/impl.rs Outdated Show resolved Hide resolved
server/src/traq/channel/impl.rs Outdated Show resolved Hide resolved
@helgev-traP
Copy link
Contributor Author

なおしました

Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO dfsなんとかする

server/src/traq/channel.rs Show resolved Hide resolved
@helgev-traP helgev-traP force-pushed the server-impl-traq-channel-service branch from 4adbe4e to 260f9ae Compare January 25, 2025 14:03
server/src/traq/channel/impl.rs Outdated Show resolved Hide resolved
@H1rono H1rono merged commit ece7988 into main Jan 25, 2025
4 checks passed
@H1rono H1rono deleted the server-impl-traq-channel-service branch January 25, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants