impl ExploreService #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helgev-traP
force-pushed
the
server-impl-explore-service
branch
from
47503bb to
32d0752
Compare
|
filter out unrelatedは collect newly containedは今は新しい位置と古い位置の両方で
|
H1rono
requested changes
Jan 25, 2025
|
filter_mapを使うようにしました。 |
helgev-traP
force-pushed
the
server-impl-explore-service
branch
from
b004d7d to
ea9960b
Compare
H1rono
reviewed
Jan 25, 2025
helgev-traP
force-pushed
the
server-impl-explore-service
branch
from
cf56a4e to
741a6c6
Compare
|
matchを切り出した。 Eventの範囲判定忘れてたので書いた。 |
H1rono
requested changes
Jan 25, 2025
helgev-traP
force-pushed
the
server-impl-explore-service
branch
from
cad5d24 to
2ff976f
Compare
H1rono
reviewed
Jan 25, 2025
server/src/explore/impl.rs
Outdated
| + ProvideExplorerService, | ||
| { | ||
| async_stream::try_stream! { | ||
| let (id, mut exploration_field_stream) = (params.id, params.stream); |
There was a problem hiding this comment.
Suggested change
| let (id, mut exploration_field_stream) = (params.id, params.stream); | |
| let super::ExploreParams { id, stream: mut exploration_field_stream } = params; |
H1rono
reviewed
Jan 25, 2025
server/src/explore/impl.rs
Outdated
Comment on lines
560
to
563
| let x_min = center.x - size.width / 2; | ||
| let x_max = center.x + size.width / 2; | ||
| let y_min = center.y - size.height / 2; | ||
| let y_max = center.y + size.height / 2; |
There was a problem hiding this comment.
u32::saturating_addとか使って欲しいです
https://doc.rust-lang.org/std/primitive.u32.html#method.saturating_add
helgev-traP
changed the title
H1rono
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.