Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl ReactionService #52

Merged
merged 10 commits into from
Jan 24, 2025
Merged

impl ReactionService #52

merged 10 commits into from
Jan 24, 2025

Conversation

ras0q
Copy link
Member

@ras0q ras0q commented Jan 23, 2025

close #47

@ras0q ras0q requested a review from H1rono January 23, 2025 15:39
H1rono
H1rono requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえず

server/migrations/2_init_reaction.sql Outdated Show resolved Hide resolved
server/src/reaction.rs Show resolved Hide resolved
server/src/reaction.rs Outdated Show resolved Hide resolved
server/src/reaction/error.rs Outdated Show resolved Hide resolved
server/src/reaction/grpc.rs Show resolved Hide resolved
server/src/reaction/grpc.rs Outdated Show resolved Hide resolved
server/src/reaction/impl.rs Outdated Show resolved Hide resolved
@ras0q ras0q force-pushed the feat/reaction-impl branch from 453afe0 to 1e560c6 Compare January 24, 2025 00:25
@ras0q ras0q requested a review from H1rono January 24, 2025 00:42
H1rono
H1rono requested changes Jan 24, 2025
View reviewed changes
server/src/reaction.rs Outdated Show resolved Hide resolved
server/src/reaction/impl.rs Outdated Show resolved Hide resolved
@ras0q ras0q requested a review from H1rono January 24, 2025 12:36
H1rono
H1rono reviewed Jan 24, 2025
View reviewed changes
server/src/reaction/impl.rs Outdated Show resolved Hide resolved
H1rono
H1rono approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@H1rono H1rono force-pushed the feat/reaction-impl branch from af0d32d to 18d2a79 Compare January 24, 2025 13:18
@H1rono H1rono merged commit 25b6000 into main Jan 24, 2025
3 checks passed
@H1rono H1rono deleted the feat/reaction-impl branch January 24, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H1rono H1rono H1rono approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

server: ReactionServiceの実装
2 participants
@ras0q @H1rono