Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💥 WebSocket書き直した #154

Merged
merged 6 commits into from
Jan 29, 2025
Merged

💥 WebSocket書き直した #154

merged 6 commits into from
Jan 29, 2025

Conversation

H1rono
Copy link
Member

@H1rono H1rono commented Jan 27, 2025

No description provided.

@H1rono H1rono requested a review from SSlime-s January 27, 2025 15:37
@H1rono
Copy link
Member Author

H1rono commented Jan 27, 2025

explorer増殖問題がようやく分かったんだけど、notify_close.notified受け取った後にevent_rxを何回か待ってあげる必要があった

SSlime-s
SSlime-s approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@SSlime-s SSlime-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ざっと見ただけだけど良さげ

:arigataya;

@H1rono H1rono merged commit 60e6133 into main Jan 29, 2025
4 checks passed
@H1rono H1rono deleted the webusoketto branch January 29, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSlime-s SSlime-s SSlime-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@H1rono @SSlime-s