-
-
Notifications
You must be signed in to change notification settings - Fork 399
Dev/swig 4 4 0 #1461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tpaviot
wants to merge
3
commits into
master
Choose a base branch
from
dev/swig-4-4-0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev/swig 4 4 0 #1461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR upgrades the SWIG dependency to version 4.4.0 and expands the CI matrix to include Python 3.13 on Ubuntu, macOS, and Windows, while standardizing existing macOS job names. Class diagram for updated SWIG dependency version in build configurationclassDiagram
class BuildConfiguration {
+Python3_LIBRARY_RELEASE : string
+SWIG_VERSION : string
+SWIG_FILES_PATH : string
+find_package(SWIG 4.2.1...4.4.0 REQUIRED)
}
class CondaMetaYaml {
+swig ==4.4.0
+python
+ninja
+cmake
}
BuildConfiguration --> CondaMetaYaml
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `azure-pipelines.yml:67-70` </location>
<code_context>
- template: conda-build.yml
parameters:
- name: macOS_12_python312
+ name: macOS_latest_python312
vmImage: 'macOS-latest'
py_maj: 3
</code_context>
<issue_to_address>
**suggestion:** Duplicate job names for macOS_latest_python312 with different Python minor versions may cause confusion.
Rename the Python 3.13 job to accurately reflect its version and prevent ambiguity in logs and results.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
3a2be23 to
eddadcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update CI to support Python 3.13 across platforms and upgrade SWIG dependency to 4.4.0
New Features:
Enhancements:
CI: