Repository navigation
🐛 fix(detect): drop stale UTF-32 BOM test cases - #967
Merged
gaborbernat merged 2 commits intoOct 1, 2026
Merged
Conversation
Merging this PR will improve performance by 87.39%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_feature[conformance-sections-heading] |
2.1 ms | 1.1 ms | +87.39% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing gaborbernat:fix/detect-stale-utf32-cases (e9a9325) with main (6d446a1)
Footnotes
-
32 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
llvm-cov attributes the unexecuted fall-through of the arena-OOM guard added in tox-dev#956 to its closing brace, so every macOS coverage job reports xsd.h:1369 missed and fails the 100% line gate; gcc does not count the brace, so Linux stays green. Mark it the way conformance.c and schema.c mark the same brace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#961 and #964 each passed CI on their own base, but they conflict once both are on main. #961 added two cases that decode UTF-32 byte-order-mark input through
detect(), and #964 dropped UTF-32 from byte-order-mark detection to follow the WHATWG BOM sniff, which recognizes only the UTF-8 and UTF-16 marks. Those bytes now detect as UTF-16LE and windows-1252, the same asparse(), so the two cases fail on main.This removes the two stale cases. The UTF-8 and UTF-16 cases in the same parametrization still cover the replacing byte-order-mark codecs, and
detect.pyhas no UTF-32 branch left for them to reach.Main's macOS jobs also fail the C line gate at 99.9%. #956 added an arena-OOM guard to
xsd.hwhose body carriesGCOVR_EXCL_LINE, but llvm-cov attributes the unexecuted fall-through to the closing brace on its own line, while gcc does not count it, so Linux stays at 100%. The brace now carries the same exclusionconformance.candschema.cuse for this pattern.closes #968