Repository navigation
🐛 fix(fuzz): compile out replay helpers in fuzz mode - #1236
Merged
Merged
Conversation
The IDNA, phone and JS harnesses define their file-replay helpers in every build, but only main() calls them. A libFuzzer build with -DTH_IDNA_FUZZ, -DTH_PHONE_FUZZ or -DJM_FUZZ drops main(), so clang's -Wunused-function turns the helpers into errors under -Werror. Each harness now opens its entry-point switch above the replay helpers, so the libFuzzer build leaves them out, and the replay build keeps them.
Merging this PR will regress 1 benchmark
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IDNA, phone and JS harnesses define their file-replay helpers in every build, but only
main()calls them. A libFuzzer build with-DTH_IDNA_FUZZ,-DTH_PHONE_FUZZor-DJM_FUZZdropsmain(), so-Werrorstops on-Wunused-functionforrun_builtinsandrun_file, plusrun_dumpin the phone harness. #1225 moved the JS entry point behindJM_FUZZand left its helpers in the same state.Each harness now opens its
#ifdefentry-point switch above the replay helpers, so the libFuzzer build leaves them out and the replay build keeps them. With clang 18,-Wall -Wextra -Werrornow builds all six harness and mode pairs, and each libFuzzer binary runs 2,000 inputs clean under ASan and UBSan.