Skip to content

fix(rng): reject resource references without href - #1199

Merged
gaborbernat merged 3 commits into
tox-dev:mainfrom
gaborbernat:fix/rng-inline-resource-labels-1016
Oct 7, 2026
Merged

gaborbernat merged 3 commits into
tox-dev:mainfrom
gaborbernat:fix/rng-inline-resource-labels-1016

Conversation

@gaborbernat

@gaborbernat gaborbernat commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Users can compile <externalRef/> and <include/> without the href required by the RELAX NG full syntax. Reject these incomplete patterns in roots, reachable patterns and unused definitions.

The Jing label runner now compares the two inline missing-attribute cases as compilation rejections. This completes their ordinary compilation checks in #1016.

This builds on the private-tree annotation removal and unused-reference traversal merged in #1198.

The Atheris environment includes the structural reducer’s tinycss2 dependency so the public consumer inventory can import.

@gaborbernat gaborbernat added the bug Something isn't working label Oct 7, 2026
@gaborbernat
gaborbernat marked this pull request as ready for review October 7, 2026 05:24
Missing href is a compilation error before RELAX NG resource resolution.
Check unused definitions through the existing traversal, and compare the
inline Jing labels instead of skipping them. Refs tox-dev#1016.
@gaborbernat
gaborbernat force-pushed the fix/rng-inline-resource-labels-1016 branch from 6538215 to bc7fd28 Compare October 7, 2026 05:42
@codspeed

codspeed Bot commented Oct 7, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 579 untouched benchmarks
⏩ 32 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ test_feature[select-relative-sibling] 43.2 µs 45.5 µs -5%
⚡ test_feature[shadow-slot-comments] 110.3 µs 83.6 µs +31.9%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing gaborbernat:fix/rng-inline-resource-labels-1016 (bc7fd28) with main (9ff1626)

Open in CodSpeed

Footnotes

  1. 32 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@gaborbernat
gaborbernat merged commit 86825f1 into tox-dev:main Oct 7, 2026
92 of 96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant