Repository navigation
fix(rng): reject resource references without href - #1199
Merged
gaborbernat merged 3 commits intoOct 7, 2026
Merged
Conversation
gaborbernat
marked this pull request as ready for review
October 7, 2026 05:24
Missing href is a compilation error before RELAX NG resource resolution. Check unused definitions through the existing traversal, and compare the inline Jing labels instead of skipping them. Refs tox-dev#1016.
gaborbernat
force-pushed
the
fix/rng-inline-resource-labels-1016
branch
from
October 7, 2026 05:42
6538215 to
bc7fd28
Compare
Merging this PR will regress 1 benchmark
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | test_feature[select-relative-sibling] |
43.2 µs | 45.5 µs | -5% |
| ⚡ | test_feature[shadow-slot-comments] |
110.3 µs | 83.6 µs | +31.9% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing gaborbernat:fix/rng-inline-resource-labels-1016 (bc7fd28) with main (9ff1626)
Footnotes
-
32 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can compile
<externalRef/>and<include/>without thehrefrequired by the RELAX NG full syntax. Reject these incomplete patterns in roots, reachable patterns and unused definitions.The Jing label runner now compares the two inline missing-attribute cases as compilation rejections. This completes their ordinary compilation checks in #1016.
This builds on the private-tree annotation removal and unused-reference traversal merged in #1198.
The Atheris environment includes the structural reducer’s
tinycss2dependency so the public consumer inventory can import.