Repository navigation
feat(fuzz): add structural reduction - #1195
Merged
Merged
Conversation
Character deletion can leave unrelated language constructs in saved findings. Use DOM subtree and attribute deletion, parsed CSS declarations and a pinned UglifyJS AST fork before character reduction. Keep the original finding predicate and share the 600-comparison limit across structural reduction and separate JSON fields. Refs tox-dev#1019
Merging this PR will degrade performance by 6.2%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | test_feature[prune-shared-single] |
88.7 µs | 96.1 µs | -7.7% |
| ❌ | test_feature[text-content] |
2.6 ms | 2.8 ms | -6.21% |
| ❌ | test_feature[select-relative-sibling] |
42.6 µs | 45.3 µs | -6.1% |
| ❌ | test_feature[serialize-inner] |
5.1 ms | 5.4 ms | -5.64% |
| ❌ | test_feature[serialize-inner-indent] |
5.5 ms | 5.9 ms | -5.32% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing gaborbernat:feat/fuzz-reduce-1019 (e7a31c3) with main (59b515e)
Footnotes
-
32 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Character-only minimization can leave unrelated HTML elements or CSS declarations in saved findings. This adds subtree and attribute deletion for HTML, declaration deletion within parsed CSS rules, and JavaScript AST reduction for #1019.
The JavaScript reducer forks the pinned UglifyJS reducer with UglifyJS 3.19.3 and checks candidates through the original finding predicate. CSS reduction uses tinycss2 1.5.1 block parsing. Structural and character reduction share the 600-comparison limit across JSON fields. MSan and operation-VM TSan remain requirements for completing #1019.