Repository navigation
👷 ci: move arm64 MSVC setup off Node 20, bump deps - #1043
Merged
Merged
Conversation
Merging this PR will degrade performance by 5.47%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | test_feature[transform-number-count-last] |
553.2 µs | 585.2 µs | -5.47% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing gaborbernat:ci/gha-annotations (e5bfc02) with main (6faa471)
Footnotes
-
32 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
readability-lxml 0.9 caps chardet below 6, which conflicts with the chardet>=7.6 pin in the same group, so the type env failed to resolve.
gaborbernat
force-pushed
the
ci/gha-annotations
branch
from
October 3, 2026 04:56
6a0d876 to
e5bfc02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ilammy/msvc-dev-cmdstill declares Node 20 and has not shipped a release since January 2024, so the arm64 MSVC cell warned about the Node 20 deprecation on every run.TheMrMilchmann/setup-msvc-devv4.1.0 runs on Node 24 and handsarch: arm64tovcvarsall.bat, so meson picks up the same native toolchain.📦 While touching the workflows I bumped the GitHub Actions pins, pre-commit hooks, Python dependency floors and lockfiles to their latest releases, one commit per kind.
The newer hooks reformatted a few files; those changes sit in their own commit.
ilammy/msvc-dev-cmdv1.13.0, the commit the arm64 cell pinned, declaresnode20, which GitHub deprecated on Actions runners and now forces onto Node 24 with a warning. setup-msvc-dev v4.1.0 declaresnode24and passesarchtovcvarsall.batunchanged.