Skip to content

👷 ci: move arm64 MSVC setup off Node 20, bump deps - #1043

Merged
gaborbernat merged 7 commits into
tox-dev:mainfrom
gaborbernat:ci/gha-annotations
Oct 3, 2026
Merged

gaborbernat merged 7 commits into
tox-dev:mainfrom
gaborbernat:ci/gha-annotations

Conversation

@gaborbernat

@gaborbernat gaborbernat commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

ilammy/msvc-dev-cmd still declares Node 20 and has not shipped a release since January 2024, so the arm64 MSVC cell warned about the Node 20 deprecation on every run. TheMrMilchmann/setup-msvc-dev v4.1.0 runs on Node 24 and hands arch: arm64 to vcvarsall.bat, so meson picks up the same native toolchain.

📦 While touching the workflows I bumped the GitHub Actions pins, pre-commit hooks, Python dependency floors and lockfiles to their latest releases, one commit per kind.

The newer hooks reformatted a few files; those changes sit in their own commit.

ilammy/msvc-dev-cmd v1.13.0, the commit the arm64 cell pinned, declares node20, which GitHub deprecated on Actions runners and now forces onto Node 24 with a warning. setup-msvc-dev v4.1.0 declares node24 and passes arch to vcvarsall.bat unchanged.

@codspeed

codspeed Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 5.47%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 580 untouched benchmarks
⏩ 32 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ test_feature[transform-number-count-last] 553.2 µs 585.2 µs -5.47%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing gaborbernat:ci/gha-annotations (e5bfc02) with main (6faa471)

Open in CodSpeed

Footnotes

  1. 32 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@gaborbernat
gaborbernat merged commit e1c1a77 into tox-dev:main Oct 3, 2026
54 of 55 checks passed
@gaborbernat
gaborbernat deleted the ci/gha-annotations branch October 3, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant