v3 #1423
Draft
v3 #1423
+2,085
−1,292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People can be co-author:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: -8.23 kB (-11.68%) 👏 Total Size: 62.2 kB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1423 +/- ##
==========================================
- Coverage 76.16% 76.04% -0.13%
==========================================
Files 74 71 -3
Lines 621 576 -45
Branches 135 124 -11
==========================================
- Hits 473 438 -35
+ Misses 141 133 -8
+ Partials 7 5 -2
🚀 New features to boost your workflow:
|
🦋 Changeset detectedLatest commit: 56ae4eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Poco <[email protected]> Co-authored-by: Juhyeok Kang <[email protected]>
…error (#1409) 🚧 This PR could make a huge difference, so please help us make sure this change gets a very thorough review. 🚧 ```tsx const Throw = { Error: ({ message, after = 0, children }: PropsWithChildren<{ message: string; after?: number }>) => { const [isNeedThrow, setIsNeedThrow] = useState(after === 0) if (isNeedThrow) { throw new Error(message) } useTimeout(() => setIsNeedThrow(true), after) return <>{children}</> } } const Example = () => ( <ErrorBoundary fallback={() => <>This is expected</>}> <ErrorBoundary fallback={() => ( <Throw.Error message={ERROR_MESSAGE} after={100}> ErrorBoundary's fallback before error </Throw.Error> )} > <Throw.Error message={ERROR_MESSAGE} after={100}> ErrorBoundary's children before error </Throw.Error> </ErrorBoundary> </ErrorBoundary> ) ``` ## Problem: ErrorBoundary's fallback can't be treated by parent ErrorBoundary <!-- A clear and concise description of what this pr is about. --> Thrown Error in fallback will be caught by ErrorBoundary self and then expose fallback recursively 🥲 1. ErrorBoundary's children before error 2. ErrorBoundary's fallback before error 3. ErrorBoundary's fallback before error 4. ErrorBoundary's fallback before error 5. ... expose fallback self recursively ... ## Solution: When we meet thrown error in fallback of ErrorBoundary wrap it as InternalFallbackError, re-throw InternalFallbackError.fallbackError, if it is InternalFallbackError Thrown Error in fallback will be caught by parent ErrorBoundary 👍 1. ErrorBoundary's children before error 2. ErrorBoundary's fallback before error 3. This is expected ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 5. I added documents and tests. --------- Co-authored-by: Lee HyunJae (whale) <[email protected]> Co-authored-by: lucas0530 <[email protected]> Co-authored-by: HYUNGU KANG <[email protected]> Co-authored-by: Brian Vaughn <[email protected]>
…l to sequential (#1488) # Overview <!-- A clear and concise description of what this pr is about. --> Fix file system conflicts during JSR publish by executing commands sequentially instead of in parallel. ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests.
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @suspensive/[email protected] ### Patch Changes - [#1488](#1488) [`71f8259`](71f8259) Thanks [@kangju2000](https://github.com/kangju2000)! - fix: fix JSR publish failures by changing execution flow from parallel to sequential ## @suspensive/[email protected] ### Patch Changes - Updated dependencies \[]: - @suspensive/[email protected] - @suspensive/[email protected] ## @suspensive/[email protected] ## @suspensive/[email protected] ## @suspensive/[email protected] ## @suspensive/[email protected] ## @suspensive/[email protected]
# Overview add `mutationOptions` as an experimental API. ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --------- Co-authored-by: MinuKang <[email protected]> Co-authored-by: bluejoyq <[email protected]> Co-authored-by: Jonghyeon Ko <[email protected]>
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @suspensive/[email protected] ### Minor Changes - [#1490](#1490) [`a37dd3d`](a37dd3d) Thanks [@gwansikk](https://github.com/gwansikk)! - feat(react-query): add `mutationOptions` ## @suspensive/[email protected] ### Minor Changes - [#1490](#1490) [`a37dd3d`](a37dd3d) Thanks [@gwansikk](https://github.com/gwansikk)! - feat(react-query): add `mutationOptions` ## @suspensive/[email protected] ### Patch Changes - Updated dependencies \[[`a37dd3d`](a37dd3d)]: - @suspensive/[email protected] - @suspensive/[email protected] ## @suspensive/[email protected] ## @suspensive/[email protected] ## @suspensive/[email protected] ## @suspensive/[email protected]
# Overview
<!--
A clear and concise description of what this pr is about.
-->
Attempting to resolve JSR publishing issue. Testing with
@suspensive/react package first.
Related issues:
- jsr-io/jsr#526
- jsr-io/jsr#632
- jsr-io/jsr#24
- jsr-io/jsr/discussions/399
## PR Checklist
- [x] I did below actions if need
1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @suspensive/[email protected] ### Patch Changes - [#1494](#1494) [`d13bd42`](d13bd42) Thanks [@kangju2000](https://github.com/kangju2000)! - fix: Add React import to jsr.json ## @suspensive/[email protected] ### Patch Changes - Updated dependencies \[]: - @suspensive/[email protected] - @suspensive/[email protected] ## @suspensive/[email protected] ## @suspensive/[email protected] ## @suspensive/[email protected] ## @suspensive/[email protected] ## @suspensive/[email protected]
…#1497) # Overview <!-- A clear and concise description of what this pr is about. --> Enhanced JSR synchronization script to optimize dependency management and applied consistent formatting to all package jsr.json files. Additionally, we need to add CI publishing permissions for all `@suspensive` packages on JSR. Currently, only `@suspensive/react` has CI publishing enabled. As mentioned in #1485 (comment), we need to link the remaining packages under the 'Publish from CI' section on https://jsr.io/@suspensive. ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests.
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @suspensive/[email protected] ### Patch Changes - [#1497](#1497) [`e400035`](e400035) Thanks [@kangju2000](https://github.com/kangju2000)! - chore: improve JSR imports sync with consistent dependency formatting ## @suspensive/[email protected] ### Patch Changes - [#1497](#1497) [`e400035`](e400035) Thanks [@kangju2000](https://github.com/kangju2000)! - chore: improve JSR imports sync with consistent dependency formatting ## @suspensive/[email protected] ### Patch Changes - [#1497](#1497) [`e400035`](e400035) Thanks [@kangju2000](https://github.com/kangju2000)! - chore: improve JSR imports sync with consistent dependency formatting ## @suspensive/[email protected] ### Patch Changes - [#1497](#1497) [`e400035`](e400035) Thanks [@kangju2000](https://github.com/kangju2000)! - chore: improve JSR imports sync with consistent dependency formatting ## @suspensive/[email protected] ### Patch Changes - [#1497](#1497) [`e400035`](e400035) Thanks [@kangju2000](https://github.com/kangju2000)! - chore: improve JSR imports sync with consistent dependency formatting ## @suspensive/[email protected] ### Patch Changes - [#1497](#1497) [`e400035`](e400035) Thanks [@kangju2000](https://github.com/kangju2000)! - chore: improve JSR imports sync with consistent dependency formatting - Updated dependencies \[[`e400035`](e400035)]: - @suspensive/[email protected] - @suspensive/[email protected] ## @suspensive/[email protected] ### Patch Changes - [#1497](#1497) [`e400035`](e400035) Thanks [@kangju2000](https://github.com/kangju2000)! - chore: improve JSR imports sync with consistent dependency formatting ## @suspensive/[email protected] ### Patch Changes - [#1497](#1497) [`e400035`](e400035) Thanks [@kangju2000](https://github.com/kangju2000)! - chore: improve JSR imports sync with consistent dependency formatting
# Overview
<!--
A clear and concise description of what this pr is about.
-->
## PR Checklist
- [x] I did below actions if need
1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1108 close #1349 close #1325
Suspensive v3
PR Checklist