Skip to content

Added safety iteration bound to boost fold() #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DhanushPillay wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Added safety iteration bound to boost fold() #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Software/effects/boost.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ static float fold(float in, float level)
{
float fold_scale = 0.5;
boost_effect.intense = 1;
for (;;) {
// Cap iterations to prevent infinite loop on float precision stalls
for (int i = 0; i < 20; i++) {
float over = (in - level) * fold_scale;

in = level - over;
Expand All @@ -35,6 +36,7 @@ static float fold(float in, float level)
if (in <= level)
return in;
}
return in;
}

static float boost_step(float in)
Expand Down