Skip to content

Commit

Permalink
Don't set a pid file on EL, and use omit instead of None as the
Browse files Browse the repository at this point in the history
default since "{{ None }}" actually becomes an empty string (there isn't
a way to set a variable to None/null from a template block as far as I
can tell).
  • Loading branch information
natefoo committed Mar 27, 2019
1 parent 3a61c93 commit d18c8f9
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 20 deletions.
22 changes: 8 additions & 14 deletions defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,33 +33,29 @@ __slurm_config_default:
ProctrackType: proctrack/pgid
# slurmctld options
SlurmctldPort: 6817
SlurmctldLogFile: "{{ '/var/log/slurm-llnl/slurmctld.log' if __slurm_debian else None }}"
SlurmctldLogFile: "{{ '/var/log/slurm-llnl/slurmctld.log' if __slurm_debian else omit }}"
SlurmctldPidFile: >-
{{
'/var/run/slurm-llnl/slurmctld.pid' if __slurm_debian else (
'/var/run/slurmctld.pid' if __slurm_redhat else
None)
'/var/run/slurm-llnl/slurmctld.pid' if __slurm_debian else omit
}}
StateSaveLocation: >-
{{
'/var/lib/slurm-llnl/slurmctld' if __slurm_debian else (
'/var/lib/slurm/slurmctld' if __slurm_redhat else
None)
omit)
}}
# slurmd options
SlurmdPort: 6818
SlurmdLogFile: "{{ '/var/log/slurm-llnl/slurmd.log' if __slurm_debian else None }}"
SlurmdLogFile: "{{ '/var/log/slurm-llnl/slurmd.log' if __slurm_debian else omit }}"
SlurmdPidFile: >-
{{
'/var/run/slurm-llnl/slurmd.pid' if __slurm_debian else (
'/var/run/slurm.pid' if __slurm_redhat else
None)
'/var/run/slurm-llnl/slurmd.pid' if __slurm_debian else omit
}}
SlurmdSpoolDir: >-
{{
'/var/lib/slurm-llnl/slurmd' if __slurm_debian else (
'/var/spool/slurm/slurmd' if __slurm_redhat else
None)
omit)
}}
__slurm_config_merged: "{{ __slurm_config_default | combine(slurm_config | default({})) }}"

Expand All @@ -83,9 +79,7 @@ __slurmdbd_config_default:
SlurmUser: "{{ __slurm_user_name }}"
PidFile: >-
{{
'/var/run/slurm-llnl/slurmdbd.pid' if __slurm_debian else (
'/var/run/slurmdbd.pid' if __slurm_redhat else
None)
'/var/run/slurm-llnl/slurmdbd.pid' if __slurm_debian else omit
}}
LogFile: "{{ '/var/log/slurm-llnl/slurmdbd.log' if __slurm_debian else None }}"
LogFile: "{{ '/var/log/slurm-llnl/slurmdbd.log' if __slurm_debian else omit }}"
__slurmdbd_config_merged: "{{ __slurmdbd_config_default | combine(slurmdbd_config | default({})) }}"
5 changes: 3 additions & 2 deletions templates/generic.conf.j2
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@

{% set conf = lookup('vars', item.config) %}
{% for key in conf | sort %}
{% if conf[key] != None %}
{{ key }}={{ conf[key] }}
{% set val = conf[key] %}
{% if val is not none and val != omit %}
{{ key }}={{ 'yes' if val is sameas true else ('no' if val is sameas false else val) }}
{% endif %}
{% endfor %}
9 changes: 5 additions & 4 deletions templates/slurm.conf.j2
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,23 @@ ControlMachine=localhost

# Configuration options
{% for key in __slurm_config_merged | sort %}
{% if __slurm_config_merged[key] %}
{{ key }}={{ __slurm_config_merged[key] }}
{% set val = __slurm_config_merged[key] %}
{% if val is not none and val != omit %}
{{ key }}={{ 'YES' if val is sameas true else ('NO' if val is sameas false else val) }}
{% endif %}
{% endfor %}

# Nodes
{% for i in slurm_nodes %}
NodeName={{ i.name }}{% for k in i | sort if k != 'name' %} {{ k }}={{ i[k] }}{% endfor %}
NodeName={{ i.name }}{% for k in i | sort if k != 'name' %} {{ k }}={{ 'YES' if i[k] is sameas true else ('NO' if i[k] is sameas false else i[k]) }}{% endfor %}

{% else %}
NodeName=localhost State=UNKNOWN
{% endfor %}

# Partitions
{% for i in slurm_partitions %}
PartitionName={{ i.name }}{% for k in i | sort if k != 'name' %} {{ k }}={{ i[k] }}{% endfor %}
PartitionName={{ i.name }}{% for k in i | sort if k != 'name' %} {{ k }}={{ 'YES' if i[k] is sameas true else ('NO' if i[k] is sameas false else i[k]) }}{% endfor %}

{% else %}
PartitionName=debug Default=YES Nodes={{ (slurm_nodes[0] | default({})).name | default('localhost') }} State=UP
Expand Down

0 comments on commit d18c8f9

Please sign in to comment.