TWE-7 - BE - Division page

[SharmaineLim]

Link to Ticket

Description of Changes Made

• Add the new Division page BE, with the new blocks
  • Dynamic hero block
  • Introduction section block
  • Four photo collage block

Equivalent designs for blocks

Dynamic hero block

Introduction section block

Four photo collage block

Other changes:

• Move PartnersBlock from services.blocks to core.blocks so we can reuse it.
• Replace the HomePageFactory and StandardPageFactory unit tests with one unit test that checks that all pages have a factory.

How to Test

1. Add a child page to the homepage
2. Create a division page
3. Populate the fields and save

Screenshots

Editor

MR Checklist

• Add a description of your pull request and instructions for the reviewer to verify your work.
• If your pull request is for a specific ticket, link to it in the description.
• Stay on point and keep it small so the merge request can be easily reviewed.
• Tests and linting passes.

Unit tests

• Added
• Not required

Documentation

• Updated build docs
• Updated editor guidelines (See https://intranet.torchbox.com/torchbox-com-project-docs for the private link, for Torchbox employees only)
  • Dynamic hero block
  • Division page
• Updated field spec (See https://intranet.torchbox.com/torchbox-com-project-docs for the private link, for Torchbox employees only)
  • Division page
• Not required

Browser testing

• I have tested in the following browsers and environments (edit the list as required)
  • Latest version of Chrome on mac
  • Latest version of Firefox on mac
  • Latest version of Safari on mac
  • Safari on last two versions of iOS
  • Chrome on last two versions of Android
• Not required

Data protection

• Not relevant
• This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

• I have tested the changes in both light and dark mode
• The change is not relevant to dark and light mode

Accessibility

• Automated WCAG 2.1 tests pass
• HTML validation passes
• Manual WCAG 2.1 tests completed
• I have tested in a screen reader
• I have tested in high-contrast mode
• Any animations removed for prefers-reduced-motion
• Not required

Sustainability

• Images are optimised and lazy-loading used where appropriate
• SVGs have been optimised
• Perfomance and transfer of data considered
• If JavaScript is needed alternatives have been considered
• Not required

Pattern library

• The pattern library component for this template displays correctly, and does not break parent templates
• The styleguide is updated if relevant
• Changes are not relevant the pattern library

[zerolab]

Left a few questions and suggestions. Love the use of factoryboy post generation features.

I am missing the wider project context -- what about the blocks under partner logos ("what we do", "beliefs", "sparks & kindling", "lighting little fires")?

[SharmaineLim]

I am missing the wider project context -- what about the blocks under partner logos ("what we do", "beliefs", "sparks & kindling", "lighting little fires")?

@zerolab Ah sorry I forgot to mention, those are covered by other tickets 😄 Thanks for checking! And thank you for the review~