Switch to use docker compose
#318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: `pty=True` helps with buffered output and makes the some `docker compose` commands (like build or start) much nicer
https://docs.docker.com/reference/build-checks/ `docker build --check .`
|
Likewise, this might be best to wait until the new navigation and site restructure has happened. |
|
These are minimal and would make the developer experience so much nicer ;) |
|
I've tried this locally and nothing seems broken, so I'm happy for this to be merged in. |
Thanks for testing @SharmaineLim - can you put on staging before merging? Even if it doesn't need testsing in staging it's good to keep it in sync with prod. |
|
Any objections to merging this? |
|
Looks like it's already on the staging branch, and @SharmaineLim has tested, so I will go ahead and merge to prod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ran
docker build --check .(ref)