E2e model quality upstream - #853
Draft
yannicks1 wants to merge 24 commits into
Draft
Conversation
Compare compiled Spyre output for the product decoder and embedding models against cached CPU HF references, under a new model_quality marker with its own CI job. gemma-4-31B is gated on short prompts only: it drifts from HF as the prompt grows because torch-spyre normalises in fp16. Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
…utions Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
…ill bucket Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
…t step coverage Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
…sion as unpinned Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
… refs Drop the checked-in reference JSONs and the scripts that generated them. Each gate now computes its HF side in-run through upstream vLLM's HfRunner and judges it with upstream's own check_logprobs_close / check_embeddings_close, reached through the pinned tests/ tree the upstream suite already clones. That clone helper moves out of pytest_plugin.py into spyre_testing_plugin/ upstream.py. Since tests.* now resolves to upstream's package rather than this repo's directory, sibling test modules import each other as top-level modules. Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Contributor
|
👋 Hi! Thank you for contributing. We also recommend installing prek and configuring it to check your code before every local commit. |
Contributor
|
📖 This PR includes doc changes. Download the preview (built from uv pip install -r docs/requirements-docs.txt
mkdocs serve |
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Test Plan
Checklist
bash format.sh)Signed-off-by:line (DCO compliance)