[Feature] Enable FP32 RMSNorm - #845
Open
bohnstingl wants to merge 9 commits into
Open
Conversation
Signed-off-by: Thomas Ortner <boh@zurich.ibm.com>
bohnstingl
requested review from
a team,
dilipgb and
yannicks1
as code owners
September 10, 2026 17:35
Contributor
|
👋 Hi! Thank you for contributing. We also recommend installing prek and configuring it to check your code before every local commit. |
Signed-off-by: Thomas Ortner <boh@zurich.ibm.com>
…s_norm-fix Signed-off-by: Thomas Ortner <boh@zurich.ibm.com>
Signed-off-by: Thomas Ortner <boh@zurich.ibm.com>
Signed-off-by: Thomas Ortner <boh@zurich.ibm.com>
Signed-off-by: Thomas Ortner <boh@zurich.ibm.com>
Signed-off-by: Thomas Ortner <boh@zurich.ibm.com>
Signed-off-by: Thomas Ortner <boh@zurich.ibm.com>
…s_norm-fix Signed-off-by: Thomas Ortner <boh@zurich.ibm.com>
Collaborator
|
@bohnstingl it looks like there's still a test failure here, and then the way that the test fails seems to hold the card open causing the next couple tests to fail :( I'd hope that fixing the behavior leading to the failing test would fix the card busy problem too, but seems like there's still work to do here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the use of vLLM's native RMSNorm implementations.
We still need to keep our own custom OOT, as we need to enforce compilation.
Alternative to #742
Related Issues
#667 and #817
Test Plan
The behavior should be transparent to the user, so all existing tests should suffice.
Checklist
bash format.sh)Signed-off-by:line (DCO compliance)cc @yannicks1