Skip to content

Add online benchmarking script - #826

Open
sducouedic wants to merge 3 commits into
torch-spyre:mainfrom
sducouedic:benchmark_spyre_inference
Open

Add online benchmarking script#826
sducouedic wants to merge 3 commits into
torch-spyre:mainfrom
sducouedic:benchmark_spyre_inference

Conversation

@sducouedic

Copy link
Copy Markdown
Contributor

Adds scripts/run_benchmarks.sh, the script we use to run the online serving benchmark against spyre-inference.

Each line in param_sets describes one experiment: the script starts a vllm serve instance for it, runs vllm bench serve against it, tears the server down, then moves on to the next line. Results land in a per-config folder whose name encodes the parameters, so runs don't overwrite each other.

The header comment documents every parameter and marks the current golden benchmark config.

🤖 Generated with Claude Code

Signed-off-by: Sophie du Couédic <sop@zurich.ibm.com>
@sducouedic
sducouedic requested a review from a team as a code owner September 9, 2026 20:14
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, run ./format.sh.
Now you are good to go 🚀.

We also recommend installing prek and configuring it to check your code before every local commit.

Signed-off-by: Sophie du Couédic <sop@zurich.ibm.com>
@sducouedic
sducouedic requested a review from tdoublep September 9, 2026 20:24
Comment thread scripts/run_benchmarks.sh
Comment on lines +183 to +187
echo -e "
export SPYRE_KERNEL_CACHE=1

vllm serve $model
--max-model-len $max_context_len

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want to export SPYRE_NUM_CPUS=8 for both client and server
also want to source ~/spyre-libs/env.sh if it exists

Export SPYRE_NUM_CPUS=8 and source ~/spyre-libs/env.sh (if present)
before starting the server/client loop, so both vllm serve and
vllm bench serve pick them up.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Sophie du Couédic <sducouedic@users.noreply.github.com>
@sducouedic
sducouedic force-pushed the benchmark_spyre_inference branch from 7bdfe02 to fc87c5f Compare September 10, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant