Skip to content

Prevent linker optimization affecting dialect registration #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmahjour wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Prevent linker optimization affecting dialect registration #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3afd26
add linker flags to avoid discarding symbols that are only referenced…
bmahjour Apr 21, 2026
37441e3
only disable linker optimization for MLIR libs
bmahjour Apr 21, 2026
f3cee71
Merge branch 'main' into bmahjour/fix-dialect-registration
fabianlim May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions tools/ktir-opt/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,22 @@
get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS)
get_property(conversion_libs GLOBAL PROPERTY MLIR_CONVERSION_LIBS)
set(LIBS
set(MLIR_LIBS
${dialect_libs}
${conversion_libs}
MLIROptLib
)
set(KTDP_LIBS
MLIRKtdp
MLIRRegisterAllDialects
MLIRRegisterAllPasses
)

add_llvm_executable(ktir-opt ktir-opt.cpp)

llvm_update_compile_flags(ktir-opt)
target_link_libraries(ktir-opt PRIVATE ${LIBS})

if("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux")
set(DEPS PRIVATE -Wl,--whole-archive ${MLIR_LIBS} -Wl,--no-whole-archive ${KTDP_LIBS})
elseif("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin")
set(DEPS PRIVATE -Wl,-all_load ${MLIR_LIBS} ${KTDP_LIBS})
endif()

target_link_libraries(ktir-opt PRIVATE ${DEPS})
27 changes: 19 additions & 8 deletions tools/ktir-opt/ktir-opt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,30 @@
//
//===----------------------------------------------------------------------===//

#include "mlir/IR/Dialect.h"
#include "mlir/InitAllDialects.h"
#include "mlir/InitAllPasses.h"
#include "mlir/Tools/mlir-opt/MlirOptMain.h"

#include "mlir/IR/Dialect.h"
#include "mlir/Dialect/Affine/IR/AffineOps.h"
#include "mlir/Dialect/Arith/IR/Arith.h"
#include "mlir/Dialect/Func/IR/FuncOps.h"
#include "mlir/Dialect/Linalg/IR/Linalg.h"
#include "mlir/Dialect/Math/IR/Math.h"
#include "mlir/Dialect/MemRef/IR/MemRef.h"
#include "mlir/Dialect/SCF/IR/SCF.h"
#include "mlir/Dialect/Tensor/IR/Tensor.h"
#include "Ktdp/KtdpDialect.hpp"

int main(int argc, char **argv) {
mlir::registerAllPasses();

mlir::DialectRegistry registry;
registry.insert<mlir::ktdp::KtdpDialect>();
mlir::registerAllDialects(registry);

registry.insert<mlir::affine::AffineDialect,
mlir::arith::ArithDialect,
mlir::func::FuncDialect,
mlir::linalg::LinalgDialect,
mlir::math::MathDialect,
mlir::memref::MemRefDialect,
mlir::scf::SCFDialect,
mlir::tensor::TensorDialect,
mlir::ktdp::KtdpDialect>();

return mlir::asMainReturnCode(
mlir::MlirOptMain(argc, argv, "KTIR optimizer driver\n", registry));
Expand Down
Loading