Skip to content

avoid mypy dependency mismatch - #503

Open
arielge wants to merge 1 commit into
mainfrom
mypy_fix
Open

avoid mypy dependency mismatch#503
arielge wants to merge 1 commit into
mainfrom
mypy_fix

Conversation

@arielge

@arielge arielge commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

This prevents strange cases like this one, where mypy fails because it has a different set of dependencies

Co-authored-by: GPT 5.6 <gpt5@users.noreply.github.com>
Signed-off-by: Ariel Gera <ariel.gera1@ibm.com>
@arielge
arielge marked this pull request as ready for review September 10, 2026 11:49

@BenjSz BenjSz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BenjSz
BenjSz enabled auto-merge September 10, 2026 11:50
@spyre-ci

spyre-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown

⚙️ Auto-merge enabled — dispatched /spyre-test for ddda5fbe because the required Spyre Test gate had not run on this commit.

Automated: enabling auto-merge requests the gate, so the PR is not left waiting on a check nobody asked for. Re-enabling auto-merge on this same commit will not dispatch again.

@spyre-ci

spyre-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown

✅ spyre-test: success

Triggered by: /spyre-test comment

Plan (build waves + dependencies, per arch)

amd64

flowchart LR
  subgraph Lamd64_0["amd64 L0 · 1 parallel"]
    n_amd64_torch_spyre_torch_spyre_dev["torch-spyre/torch-spyre-dev 🟢<br/>image · a39b59f6076f"]
  end
  subgraph Lamd64_1["amd64 L1 · 1 parallel"]
    n_amd64_hf_adapters_hf_adapters_dev["hf-adapters/hf-adapters-dev 🟢<br/>image · 093807f708e9"]
  end
  subgraph Lamd64_2["amd64 L2 · 1 parallel"]
    n_amd64_spyre_inference_spyre_inference_dev["spyre-inference/spyre-inference-dev 🟢<br/>image · 58207b19e4f8"]
  end
  n_amd64_torch_spyre_torch_spyre_dev --> n_amd64_hf_adapters_hf_adapters_dev
  n_amd64_hf_adapters_hf_adapters_dev --> n_amd64_spyre_inference_spyre_inference_dev
  classDef sPending fill:#eceff1,stroke:#90a4ae,color:#37474f
  classDef sBuilding fill:#fff8e1,stroke:#f9a825,color:#5d4037,stroke-width:2px
  classDef sOk fill:#e8f5e9,stroke:#43a047,color:#1b5e20
  classDef sReused fill:#e3f2fd,stroke:#1e88e5,color:#0d47a1
  classDef sFailed fill:#ffebee,stroke:#e53935,color:#b71c1c,stroke-width:2px
  classDef sDropped fill:#f5f5f5,stroke:#bdbdbd,color:#9e9e9e
  class n_amd64_torch_spyre_torch_spyre_dev sOk;
  class n_amd64_hf_adapters_hf_adapters_dev sOk;
  class n_amd64_spyre_inference_spyre_inference_dev sOk;
Loading

✅ orch trigger-pr-validationgreen · arches amd64 · fp amd64=1f5daa9e

level component arch build smoke unit integration trunk regression perf
L0 torch-spyre/torch-spyre-dev amd64 ✅ ok · 🟢 gha · · ·
L1 hf-adapters/hf-adapters-dev amd64 ✅ ok 🟢 · 🟢 gha · · ·
L2 spyre-inference/spyre-inference-dev amd64 ✅ ok 🟢 · 🟢 gha · · ·

GHA test runs:


✅ safe to merge

Build: built 3

Tests: passed 6 · blocking 0 · advisory 0 · infra/inconclusive 0 · no signal 0

Before merging, consider:

  • Every leg that ran passed, and no leg was left without a signal, and every build cell settled.

@spyre-ci

spyre-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown

GHA test runs:

@spyre-ci

spyre-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown

GHA test runs:

@spyre-ci

spyre-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown

GHA test runs:

@BenjSz
BenjSz added this pull request to the merge queue Sep 10, 2026
@spyre-ci

spyre-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown

❌ merge-queue-integration: failure

Plan (build waves + dependencies, per arch)

amd64

flowchart LR
  subgraph Lamd64_0["amd64 L0 · 1 parallel"]
    n_amd64_spyre_backend_spyre_backend_dev["spyre-backend/spyre-backend-dev ↺<br/>image · 8fec6d997c0a"]
  end
  subgraph Lamd64_1["amd64 L1 · 1 parallel"]
    n_amd64_torch_spyre_torch_spyre_dev["torch-spyre/torch-spyre-dev 🔴<br/>image · 01cbfae31d22"]
  end
  subgraph Lamd64_2["amd64 L2 · 1 parallel"]
    n_amd64_hf_adapters_hf_adapters_dev["hf-adapters/hf-adapters-dev 🔴<br/>image · e5c7fb79fe98"]
  end
  subgraph Lamd64_3["amd64 L3 · 1 parallel"]
    n_amd64_spyre_inference_spyre_inference_dev["spyre-inference/spyre-inference-dev 🔴<br/>image · dfab42123904"]
  end
  n_amd64_spyre_backend_spyre_backend_dev --> n_amd64_torch_spyre_torch_spyre_dev
  n_amd64_torch_spyre_torch_spyre_dev --> n_amd64_hf_adapters_hf_adapters_dev
  n_amd64_hf_adapters_hf_adapters_dev --> n_amd64_spyre_inference_spyre_inference_dev
  classDef sPending fill:#eceff1,stroke:#90a4ae,color:#37474f
  classDef sBuilding fill:#fff8e1,stroke:#f9a825,color:#5d4037,stroke-width:2px
  classDef sOk fill:#e8f5e9,stroke:#43a047,color:#1b5e20
  classDef sReused fill:#e3f2fd,stroke:#1e88e5,color:#0d47a1
  classDef sFailed fill:#ffebee,stroke:#e53935,color:#b71c1c,stroke-width:2px
  classDef sDropped fill:#f5f5f5,stroke:#bdbdbd,color:#9e9e9e
  class n_amd64_spyre_backend_spyre_backend_dev sReused;
  class n_amd64_torch_spyre_torch_spyre_dev sOk;
  class n_amd64_hf_adapters_hf_adapters_dev sOk;
  class n_amd64_spyre_inference_spyre_inference_dev sOk;
Loading

✅ orch trigger-pr-validationgreen · arches amd64 · fp amd64=47d58f10

level component arch build smoke unit integration trunk regression perf
L0 spyre-backend/spyre-backend-dev amd64 ✅ ok (reused) · · · · · ·
L1 torch-spyre/torch-spyre-dev amd64 ✅ ok 🟢 · 🟡 gha · · ·
L2 hf-adapters/hf-adapters-dev amd64 ✅ ok 🟢 · · · 🟡 gha ·
L3 spyre-inference/spyre-inference-dev amd64 ✅ ok 🟢 · 🟡 gha · · ·

GHA test runs:


❔ inconclusive — infra failure, no test signal; re-run

Build: built 3 · reused 1

Tests: passed 1 · blocking 0 · advisory 3 · infra/inconclusive 2 · no signal 2

Failures by kind
  • INFRA (no test signal) · hf-adapters/amd64 gha:regression: FAILURE — 📦 infra: capacity
    • Not your change. The agent or runner could not carry the job -- re-run.
  • INFRA (no test signal) · spyre-inference/amd64 gha:integration: FAILURE — 📦 infra: capacity
    • Not your change. The agent or runner could not carry the job -- re-run.
  • ⚠️ advisory (does not block) · hf-adapters/amd64 regression: UNSTABLE
  • ⚠️ advisory (does not block) · torch-spyre/amd64 integration: UNSTABLE
  • ⚠️ advisory (does not block) · torch-spyre/amd64 gha:integration: FAILURE

Before merging, consider:

  • hf-adapters/amd64 gha:regression, spyre-inference/amd64 gha:integration produced no test signal — the leg failed on infrastructure (runner set never became ready, monitor gave up, or the result record was lost), not on this PR's code. Do not read this as a pass OR a failure: re-run to get a verdict.
  • hf-adapters/amd64 regression, torch-spyre/amd64 gha:integration, torch-spyre/amd64 integration failed with gating: "unstable" — advisory. It set the build UNSTABLE but does not block the merge. Worth a look, not a stop.

@spyre-ci

spyre-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown

GHA test runs:

@spyre-ci

spyre-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown

GHA test runs:

@spyre-ci

spyre-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown

GHA test runs:

@arielge
arielge removed this pull request from the merge queue due to a manual request Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants