Limit PR test matrices for adapter-only changes - #474
Conversation
|
@assaftibm could you please fix the conflict? |
| if all(_is_documentation_path(path) for path in normalized): | ||
| return set() | ||
| if not all(_is_hf_adapter_path(path) for path in normalized): | ||
| return None |
There was a problem hiding this comment.
This is perhaps overly conservative - as usually when someone adds an adapter they also update the documentation
There was a problem hiding this comment.
Something else - we must have special treatment of hf_common.py - changes there must trigger comprehensive testing, but currently it is treated like any other adapter
There was a problem hiding this comment.
I think in the case of hf_common.py almost all the adapters will be tested.
There was a problem hiding this comment.
right, but shouldn't we explicitly guarantee this?
| QUESTION_ANSWERING = "question_answering_matrix" | ||
| TOKEN_CLASSIFICATION = "token_classification_matrix" | ||
| RERANKER = "reranker_matrix" | ||
| COMBINED = "combined_matrix" |
There was a problem hiding this comment.
there is also seq_classification now
There was a problem hiding this comment.
may be solved with the conflict merge....
There was a problem hiding this comment.
it is indeed the same thing, but still can be easily missed...
3 participants
Summary
hf_adapters/hf_*.pyfileTesting
.venv/bin/python -m pytest --noconftest tests/test_filter_test_matrix.py -q.venv/bin/python -m ruff check .github/scripts/filter_test_matrix.py tests/test_filter_test_matrix.py