Skip to content

fix(op-test): limit randint value for setitem #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kiszk wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −6
Open

fix(op-test): limit randint value for setitem #421

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58e790b
initial commit
kiszk Aug 25, 2026
7a5eeac
Merge branch 'main' into fix/model-ops-config-setitem-randint
kiszk Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions utils/model_ops/utils/torchop_yaml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,19 +416,25 @@ def _resolve_node_comments(comments):
"torch.index_select",
"torch.select_scatter",
]
_SPECIAL_INTLIMIT_OPS = _INDEX_INTLIMIT_OPS + ["torch.getitem"]
_SPECIAL_INTLIMIT_OPS = _INDEX_INTLIMIT_OPS + ["torch.getitem", "torch.setitem"]

@staticmethod
def _compute_randintlimit(op_name, i, dtype, saved_shape, san_args):
if op_name not in TorchOpCollector._SPECIAL_INTLIMIT_OPS:
return 1000
if i == 0:
return 1000
if op_name == "torch.getitem" and "int" in str(dtype):
TorchOpCollector.log_function[TorchOpCollector.log_mthd](
f"i: {i}, saved_shape: {saved_shape}, op_name: {op_name}, dtype: {dtype}, san_args: {san_args}"
)
return saved_shape[0]
# getitem/setitem: ``a[idx]`` / ``a[idx] = v`` index dim 0 of arg 0, so the
# index tensor at i == 1 is bounded by saved_shape[0]. Guard on i to avoid
# bounding setitem's value tensor (i == 2), which carries no index
# semantics even when its dtype is integral.
if op_name in ("torch.getitem", "torch.setitem"):
if i == 1 and "int" in str(dtype) and saved_shape:
TorchOpCollector.log_function[TorchOpCollector.log_mthd](
f"i: {i}, saved_shape: {saved_shape}, op_name: {op_name}, dtype: {dtype}, san_args: {san_args}"
)
return saved_shape[0]
return 1000
if op_name in TorchOpCollector._INDEX_INTLIMIT_OPS:
dim_index = 2 if op_name == "torch.select_scatter" else 1
if i == dim_index + 1 and "int" in str(dtype):
Expand Down
Loading