Skip to content

Inconsistent code revisions in CI runs #479

Description

@arielge

The different jobs in test_pull_request have two types of behavior in terms of which HF adapters commit they run on:

  • The regular jobs (load, smoke etc.) use build-hf-adapters, which does checkout of the PR-head commit (PR_HEAD_SHA)
  • Other jobs (generating test matrices, pre-commit, adapter coverage etc.) use just actions/checkout, which uses GITHUB_SHA - a synthetic merge commit of the PR with the latest main.

So whenever the PR is not up-to-date with main, this can lead to strange discrepancies - for example, the test matrix includes models with adapters that are not yet in the PR code (because in the GitHub synthetic head they exist), and then these matrix entries try to run in the PR code and naturally fail.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions