Added missing ktdf_arch mapping APIs. - #42
Merged
Merged
Conversation
KFAFSP
requested review from
Prasanth-Chatarasi,
acgatea1,
ani300,
bmahjour,
lupalby,
mudhakar,
viji560 and
vswagath1989
as code owners
September 18, 2026 13:05
KFAFSP
force-pushed
the
kfaf/hotfix-4
branch
from
September 18, 2026 13:27
4846262 to
ad85775
Compare
- Improved `mlir::ktdf_arch::Mappable` interface method documentation. - Added `getFromOpaquePointer` to the named attribute constraints to allow using them in `llvm::DenseMap`. - Added `llvm::PointerLikeTypeTraits` for `ResourceSpecAttr` to allow using them in `llvm::PointerUnion`. - Added static overloads for the `mlir::ktdf_arch::Mappable` methods that accept `mlir::Operation*` for convenience. Signed-off-by: Karl F. A. Friebel <karl.friebel@ibm.com>
KFAFSP
force-pushed
the
kfaf/hotfix-4
branch
from
September 18, 2026 13:40
ad85775 to
3362512
Compare
vswagath1989
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getFromOpaquePointerto the named attribute constraints to allow using them inllvm::DenseMap.llvm::PointerLikeTypeTraitsforResourceSpecAttrto allow using them inllvm::PointerUnion.mlir::ktdf_arch::Mappable::(g|s)et(OrInherit)MapsTooverloads for convenience.