fix(terminal): only accept actual keypresses in menus#2020
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
…l keypress and igore paste and other events
This comment was marked as resolved.
This comment was marked as resolved.
uwuclxdy
changed the title
GideonBear
requested changes
May 15, 2026
GideonBear
changed the title
GideonBear
approved these changes
May 15, 2026
Member
|
Thanks! |
Merged
Member
Author
|
yayy, thank you, no more reboot by pasting text :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Fixes #2016
Uses crossterm crate to get the keypress events and discards any other ones (like paste). Enter is used for default selection in
prompt_yesno().Standards checklist
CONTRIBUTING.mdIf this PR introduces new user-facing messages they are translatedAI involvement
Consulted with Claude about it and modified some code snippets that it gave me. Also for review.