fix(PM-1077): handled errors for certain use cases #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -46,14 +46,17 @@ const UserAddModalContent = ({ projectId, addNewProjectMember, onMemberInvited, | |||
|
|
|||
| try { | |||
| if (userPermissionToAdd === PROJECT_ROLES.COPILOT) { | |||
| const { success: invitations = [], failed } = await inviteUserToProject(projectId, { | |||
| const { success: invitations = [], failed, ...rest } = await inviteUserToProject(projectId, { | |||
There was a problem hiding this comment.
The variable rest is being destructured from the response of inviteUserToProject, but it's not clear what properties it contains. Ensure that rest.message is a valid property and handle cases where it might not exist.
| setAddUserError(error) | ||
| setIsAdding(false) | ||
| } else if (rest.message) { |
There was a problem hiding this comment.
The condition else if (rest.message) assumes that rest.message is an error message. Consider checking if rest.message is indeed an error or if it should be handled differently.
| @@ -90,7 +90,7 @@ class Users extends Component { | |||
| projectMembers, | |||
| invitedMembers: invitedMembers.map(m => ({ | |||
| ...m, | |||
| email: m.email || invitedUsers[m.userId].email | |||
| email: m.email || invitedUsers[m.userId].handle | |||
There was a problem hiding this comment.
The variable name email is now being used to store a handle. Consider renaming the variable to handle for clarity and to avoid confusion, as it no longer represents an email address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Ticket link - https://topcoder.atlassian.net/browse/PM-1077