Skip to content

fix package-lock #7163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vas3a merged 4 commits into from
Dec 16, 2025
Merged

fix package-lock #7163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d885761
fix package-lock
vas3a Dec 16, 2025
64d1871
Dockerfile: use ci instead of install
vas3a Dec 16, 2025
d2bc8b7
use "npm ci" on test job CI
vas3a Dec 16, 2025
cf1ae60
Merge pull request #7164 from topcoder-platform/fix-build
vas3a Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ jobs:
command: git config --global url."https://git@".insteadOf git://
- run:
name: App npm install
command: npm install
command: npm ci
Copy link

@github-actions github-actions bot Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
Switching from npm install to npm ci is a good choice for CI environments as it ensures a clean and consistent installation of dependencies based on the package-lock.json. However, ensure that the package-lock.json is up-to-date and correctly reflects the desired state of dependencies, as npm ci will fail if there are any discrepancies.

no_output_timeout: 20m
- save_cache:
key: test-node-modules-{{ checksum "package-lock.json" }}
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ ENV TOPGEAR_ALLOWED_SUBMISSIONS_DOMAINS=$TOPGEAR_ALLOWED_SUBMISSIONS_DOMAINS

RUN npm config set unsafe-perm true
RUN git config --global url."https://git@".insteadOf git://
RUN npm install
RUN npm ci
Copy link

@github-actions github-actions bot Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
Switching from npm install to npm ci is a good practice for CI/CD environments as it ensures a clean install based on the package-lock.json. However, ensure that the package-lock.json is up-to-date and committed to the repository to avoid potential discrepancies between local and CI environments.

RUN npm test
RUN npm run build

Expand Down
Loading
Loading