Skip to content

Conversation

@NHZEX
Copy link
Member

@NHZEX NHZEX commented May 20, 2025

暂定要解决的问题

  1. pg insert 的自增主键获取需要重构为使用 returning 的方式才能更好解决 修改pgsql兼容,在事务内,没有自增id返回时,因为sql报错,事务中止,不能提交,只能回滚 #593
  2. 需要提供一个 Model::maker 的重置方法,不然测试时全是重复的闭包
  3. 当前没有做 pg 字段转义,需要添加双引号用于避免关键字冲突

@NHZEX NHZEX marked this pull request as draft May 20, 2025 11:24
@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 24.91%. Comparing base (52668c1) to head (e914992).
Report is 22 commits behind head on 3.0.

Files with missing lines Patch % Lines
src/db/connector/Pgsql.php 97.29% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.0     #773      +/-   ##
============================================
+ Coverage     22.61%   24.91%   +2.30%     
- Complexity     3113     3130      +17     
============================================
  Files            65       65              
  Lines          7465     7502      +37     
============================================
+ Hits           1688     1869     +181     
+ Misses         5777     5633     -144     
Flag Coverage Δ
unittests 24.91% <97.29%> (+2.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liu21st liu21st marked this pull request as ready for review May 20, 2025 13:34
@liu21st liu21st merged commit c41df63 into top-think:3.0 May 20, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants