fix: send: use platform-specific root path #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using "/" was causing a silent bug later on at `fs.go:121` that is expecting platform-specific separators. See discussion at moby/buildkit#6007 Fix this by using `\\` on Windows and `/` on unix. Signed-off-by: Anthony Nandaa <[email protected]>
tonistiigi
approved these changes
Jun 5, 2025
Owner
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
I think we need to do a bit more thorough overview of the walkers and define more clearly which path should be used where. proto.Stat.Path should always be unix style while I think input path should be machine dependant. The callback path I think machine dependant but not 100% , if you look at the filterFS then it seems to be unix-style while if you look at subDirFS then it is machine-style. I think this one is correct anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using "/" was causing a silent bug later on at
fs.go:121that is expecting platform-specificseparators. See discussion at moby/buildkit#6007
Fix this by using
\\on Windows and/on unix.