misc improvements #478
Merged
misc improvements #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 434 out of 449 changed files in this pull request and generated no comments.
Files not reviewed (15)
- assets/MatDefs/LightingSprite.j3md: Language not supported
- assets/Shaders/LightingSprite.frag: Language not supported
- assets/Shaders/PostShadowSprite.vert: Language not supported
- assets/Shaders/PreShadowSprite.vert: Language not supported
- assets/Shaders/SPLightingSprite.frag: Language not supported
- src/toniarts/openkeeper/Main.java: Evaluated as low risk
- src/toniarts/openkeeper/animation/PoseTrack.java: Evaluated as low risk
- src/toniarts/openkeeper/game/FunnyCameraContol.java: Evaluated as low risk
- src/toniarts/openkeeper/cinematics/Cinematic.java: Evaluated as low risk
- src/toniarts/openkeeper/audio/plugins/decoder/LayerIIDecoder.java: Evaluated as low risk
- src/toniarts/openkeeper/audio/plugins/converter/MpegToWav.java: Evaluated as low risk
- src/toniarts/openkeeper/audio/plugins/decoder/tag/Tag.java: Evaluated as low risk
- src/toniarts/openkeeper/cinematics/CameraSweepDataEntry.java: Evaluated as low risk
- src/toniarts/openkeeper/audio/plugins/decoder/MpxReader.java: Evaluated as low risk
- src/toniarts/openkeeper/audio/plugins/MP2Loader.java: Evaluated as low risk
Trass3r
force-pushed
the
cleanup
branch
3 times, most recently
from
8442c0d to
6c957a7
Compare
There was a problem hiding this comment.
Copilot reviewed 444 out of 459 changed files in this pull request and generated no comments.
Files not reviewed (15)
- .vscode/launch.json: Language not supported
- .vscode/settings.json: Language not supported
- .vscode/tasks.json: Language not supported
- assets/MatDefs/LightingSprite.j3md: Language not supported
- assets/Shaders/LightingSprite.frag: Language not supported
- assets/Shaders/LightingSprite.vert: Language not supported
- assets/Shaders/PostShadowSprite.frag: Language not supported
- assets/Shaders/PostShadowSprite.vert: Language not supported
- assets/Shaders/PreShadowSprite.frag: Language not supported
- assets/Shaders/PreShadowSprite.vert: Language not supported
- assets/Shaders/SPLightingSprite.frag: Language not supported
- assets/Shaders/SPLightingSprite.vert: Language not supported
- src/toniarts/openkeeper/audio/plugins/decoder/tag/TagContent.java: Evaluated as low risk
- src/toniarts/openkeeper/audio/plugins/decoder/LayerIIDecoder.java: Evaluated as low risk
- src/toniarts/openkeeper/animation/PoseTrack.java: Evaluated as low risk
tonihele
reviewed
Feb 2, 2025
tonihele
reviewed
Feb 2, 2025
tonihele
approved these changes
Feb 2, 2025
also avoids a pointless daemon thread
- JME's LodControl is not suitable, even with lowered thresholds - also sets levels independently for each submesh - a mesh split among subgroups due to number of triangles isn't handled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.