-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/tooltip autoscroll #468
Conversation
…lation to effect length
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 suggestion.
Files not reviewed (2)
- assets/Interface/GameHUD.xml: Language not supported
- assets/Interface/MyControls.xml: Language not supported
Comments skipped due to low confidence (2)
src/toniarts/openkeeper/gui/nifty/autoscrolltext/AutoScrollTextControl.java:43
- The logger should be named 'LOGGER' to follow Java naming conventions for constants.
private static final Logger logger = System.getLogger(AutoScrollTextControl.class.getName());
src/toniarts/openkeeper/view/SystemMessageState.java:128
- The indentation of the closing brace is incorrect. It should be aligned with the opening brace of the method.
}
reverse = start < end; | ||
timeWhenChangedDirection = 0; | ||
currentXOffset = 0; | ||
speedFactor = Integer.parseInt(parameter.getProperty("length", "1000")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The speedFactor property should be parsed as a float instead of an integer for more precise control over the speed.
speedFactor = Integer.parseInt(parameter.getProperty("length", "1000")); | |
speedFactor = Float.parseFloat(parameter.getProperty("length", "1000")); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Little bit quirky. Implements the tooltip autoscroll if it doesn't entirely fit to the allocated space.
Edit: I fixed the math so that there are far less variables and more constants